Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor section 10 #233

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Refactor section 10 #233

wants to merge 17 commits into from

Conversation

tulshi
Copy link
Contributor

@tulshi tulshi commented Feb 12, 2025

Re-factored all content from the previous "Section 10: Profiles". Parts went to the "Events" section (which used to be called the "Event Properties" section), and other parts went to a newly created section called "Event Delivery".

Since this is a refactoring, no new normative language has been added. However, it adds the "event_data" field that is described in issue #221

openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
@tulshi tulshi changed the title Refactor section 10 and adds "event_data" Refactor section 10 Feb 13, 2025
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
an SSF event.

### SSF Event Properties {#event-properties}
The SSF event MAY contain additional claims within the event payload that are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed. i do think that is ok since additional claims are allowed in SETs, so not normative

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section "Event type specific fields" is supposed to be a rephrasing of this sentence that was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate Section 10 earlier in the spec
3 participants