Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ruler as output node causes crash #96

Open
lassoan opened this issue Sep 4, 2019 · 1 comment
Open

Using ruler as output node causes crash #96

lassoan opened this issue Sep 4, 2019 · 1 comment

Comments

@lassoan
Copy link
Contributor

lassoan commented Sep 4, 2019

We should not show nodes that cannot be transferred; or at least not crash but log an error if user attempts to send a non-supported MRML node.

See details here: https://discourse.slicer.org/t/openigtif-trajectory-message/8280/2
Sunderlandkyl added a commit that referenced this issue Sep 5, 2019
@Sunderlandkyl
ENH: Prevent crash when an invalid outgoing node is added to the conn…
7f42e19 
…ector node

The connector node currently only supports a limited number of outgoing node types (Volumes, Models, Transforms, Text, etc.).
Some nodes, such as vtkMRMLAnnotationRulerNode are technically "vtkMRMLModelNode", and so are listed in the node selector, but caused Slicer to crash when added as an outgoing node.
This commit should fix the crash and log an error message when an invalid outgoing node reference is added.

re #96
@Sunderlandkyl
Copy link
Contributor

7f42e19 should fix the crash.

The reason that the vtkMRMLAnnotationRulerNode is shown in the node selector is that it is a subclass of vtkMRMLModelNode, which is one of the supported types.

Do we want to send the ruler as a model through OpenIGTLink?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lassoan @Sunderlandkyl