Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add openim chat env and config #306

Merged
merged 2 commits into from
Dec 15, 2023
Merged

feat: add openim chat env and config #306

merged 2 commits into from
Dec 15, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 15, 2023 •
edited by openimbot
Loading


🔍 What type of PR is this?

/kind documentation
/kind feature

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Could you please provide a default environment variable template for openim-chat and also supply the default environment variables? Thank you.

🅰 Which issue(s) this PR fixes:

Fixes #300

Feature: Update Configuration Reading Logic and Set Default Priority for Chat Application #300

📝 Special notes for your reviewer:

🎯 Describe how to verify it

Could you please help facilitate the validation of this PR by CICD?

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@cubxxw
feat: add openim chat env and config
6b4727e 
Signed-off-by: Xinwei Xiong (cubxxw) <[email protected]>
@cubxxw cubxxw requested review from a team as code owners December 15, 2023 03:15
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 15, 2023
@cubxxw
fix: remove openim chat config file
f104c74 
Signed-off-by: Xinwei Xiong (cubxxw) <[email protected]>
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@cubxxw cubxxw added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 4f4de63 Dec 15, 2023
11 checks passed
@cubxxw cubxxw deleted the feat/set-env branch December 15, 2023 03:26
@openimsdk openimsdk locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@openimbot openimbot openimbot approved these changes

@FGadvancer FGadvancer FGadvancer approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Update Configuration Reading Logic and Set Default Priority for Chat Application
3 participants
@cubxxw @FGadvancer @openimbot