New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add a configuration method for reading environment variables #311

Closed

luhaoling wants to merge 8 commits into openimsdk:main from luhaoling:main

Contributor

luhaoling commented Dec 15, 2023

🔍 What type of PR is this?

👀 What this PR does / why we need it:

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #310

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

luhaoling and others added 7 commits

December 12, 2023 18:21


          feat: add some api about admin

01f7d4f


          fix: fix the conflect

c65ada3


          feat: add some api about admin

260101d


          fix: del the unuse method

5ba3e4c


          fix: Optimized code

505a97e


          fix: fix the userID

5f5d8bf


          Merge branch 'openimsdk:main' into main

pull-request-size bot added the size/XS label

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.
Apply: Add docstrings to all functions and file headers.


          Merge branch 'openimsdk:main' into main

Contributor

AndrewZuo01 commented Dec 17, 2023

no change here, should it close?

luhaoling closed this

openimsdk locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/XS