Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the env in config #318

Merged
merged 13 commits into from
Dec 18, 2023
Merged

fix: fix the env in config #318

merged 13 commits into from
Dec 18, 2023

Conversation

luhaoling
Copy link
Contributor


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #310

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@luhaoling luhaoling requested review from cubxxw and a team as code owners December 18, 2023 02:22
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2023
Copy link

sweep-ai bot commented Dec 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@luhaoling
Copy link
Contributor Author

recheck

@cubxxw cubxxw added this pull request to the merge queue Dec 18, 2023
Merged via the queue into openimsdk:main with commit 5823c24 Dec 18, 2023
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: fix the env in Config
3 participants