Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build-docker-image.yml #325

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Update build-docker-image.yml #325

merged 1 commit into from
Dec 18, 2023

Conversation

cubxxw
Copy link
Contributor

@cubxxw cubxxw commented Dec 18, 2023


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@cubxxw cubxxw requested review from a team as code owners December 18, 2023 07:58
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@kubbot kubbot added this pull request to the merge queue Dec 18, 2023
@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Merged via the queue into main with commit 1d61e67 Dec 18, 2023
11 checks passed
@kubbot kubbot deleted the cubxxw-patch-1 branch December 18, 2023 07:59
@openimsdk openimsdk locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@openimbot openimbot openimbot approved these changes

@kubbot kubbot kubbot approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cubxxw @kubbot @openimbot