Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The expectation is for the branch and tag versions to align with the server version #574

Closed
2 tasks done
skiffer-git opened this issue Jul 15, 2023 · 13 comments
Closed
2 tasks done
Assignees
Labels
feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. release/v3.0 Issues and pull requests related to version 3.0 of the release. This is the current version.

Comments

@skiffer-git
Copy link
Member

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the OpenIMSDK Slack and got positive feedback

Is this feature request related to a problem?

None

Problem Description

Solution Description

The expectation is for the branch and tag versions to align with the server version, and for the server to print the actual version information upon startup.

Benefits

The expectation is for the branch and tag versions to align with the server version, and for the server to print the actual version information upon startup.

Potential Drawbacks

No response

Additional Information

No response

@skiffer-git skiffer-git added the feature Categorizes issue or PR as related to a new feature. label Jul 15, 2023
@cubxxw cubxxw added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jul 25, 2023
@cubxxw cubxxw added this to the v3.1 milestone Jul 25, 2023
@kubbot
Copy link
Contributor

kubbot commented Jul 25, 2023

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨
Join slack 🤖 to connect and communicate with our developers.
If you wish to accept this assignment, please leave a comment in the comments section: /accept.🎯

@cubxxw cubxxw added area/build-release release/v3.0 Issues and pull requests related to version 3.0 of the release. This is the current version. labels Jul 25, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Jul 25, 2023

/accept

@openimbot openimbot removed this from the v3.1 milestone Jul 25, 2023
@openimbot
Copy link
Contributor

@cubxxw Glad to see you accepted this issue🤲, this issue has been assigned to you. I set the milestones for this issue to , We are looking forward to your PR!

@cubxxw
Copy link
Contributor

cubxxw commented Jul 25, 2023

The SemVer specification format is [name]x.y.z-[state+buildmetadata], for example, v2.1.5 and v1.2.3-alpha-1 +001.

@cubxxw
Copy link
Contributor

cubxxw commented Jul 25, 2023

go build -ldflags can pass the specified arguments to go tool's link in the format: -ldflags '[pattern=]arg list', for example: -X importpath.name=value.
Run go tool link -h:

root@PS2023EVRHNCXG:~/workspaces/openim/Open-IM-Server# go tool link -h  | grep "-X"
grep: option requires an argument -- 'X'
Usage: grep [OPTION]... PATTERNS [FILE]...
Try 'grep --help' for more information.
usage: link [options] main.o
  -B note
        add an ELF NT_GNU_BUILD_ID note when using ELF
  -E entry
        set entry symbol name
  -H type
        set header type
  -I linker
        use linker as ELF dynamic linker
  -L directory
        add specified directory to library path
  -R quantum
        set address rounding quantum (default -1)
  -T address
        set text segment address (default -1)
  -V    print version and exit
  -X definition
        add string value definition of the form importpath.name=value

@cubxxw
Copy link
Contributor

cubxxw commented Jul 25, 2023

You can see that -X importpath.name=value tells the Go linker to assign value to the name variable in the importpath package. Note: name must be a string variable, otherwise the compiler will report the following error

@cubxxw
Copy link
Contributor

cubxxw commented Jul 25, 2023

go build -ldflags "-X main.GitVersion=v1.0.0 -X main.BuildDate=$(date +%F)" -o version main.go

@kubbot
Copy link
Contributor

kubbot commented Sep 29, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@kubbot
Copy link
Contributor

kubbot commented Dec 6, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@cubxxw cubxxw moved this from In progress to Lifecycle states in openim-powerful Jan 3, 2024
@kubbot
Copy link
Contributor

kubbot commented Mar 2, 2024

This issue was closed because it has been stalled for 7 days with no activity.

@kubbot kubbot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 2, 2024
@github-project-automation github-project-automation bot moved this from Lifecycle states to Done in openim-powerful Mar 2, 2024
@cubxxw cubxxw reopened this Mar 2, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in openim-powerful Mar 2, 2024
@cubxxw
Copy link
Contributor

cubxxw commented Mar 11, 2024

restart

@kubbot
Copy link
Contributor

kubbot commented Mar 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


restart

@kubbot
Copy link
Contributor

kubbot commented May 20, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-project-automation github-project-automation bot moved this from In progress to Done in openim-powerful Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. release/v3.0 Issues and pull requests related to version 3.0 of the release. This is the current version.
Projects
Status: Done
Development

No branches or pull requests

4 participants