-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Self-Guided Decision Support Groundwater Modelling with Python #240
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Hi @codyalbertross, @incsanchezro, I am checking-in to see how your reviews are going. Please post your comments in this issue linked to your comments that are directly tied to the resource repo. Here is an example of how you can post your review |
I am writing to provide feedback on your paper titled "Self-Guided Decision Support Groundwater Modelling with Python.". Following the JOSE guidelines for reviewers, I would like to confirm that I have no conflicts of interest in reviewing your work. Additionally, I affirm that I have adhered to the review code of conduct of JOSE as of April 2024. Upon reviewing the paper and associated source code, I find that the overall quality of the learning framework meets essential criteria. I congratulate the authors for making the source code readily available on the specified GitHub repository. The inclusion of a generic plain-text LICENSE file reflects a commitment to open-source principles and provides clarity regarding usage rights. However, I recommend providing explicit identification of the software version as v1.0 to enhance clarity for users. Furthermore, I appreciate the integrity with which authorship and contributions to the module have been managed. The primary author's significant and visible contributions demonstrate a profound commitment to the project's success and broader educational goals. While some authors may not have been actively engaged in the GitHub repository, their contributions are appropriately acknowledged in the written paper. Overall, I recommend this paper for publication with attention to the comments listed below. I acknowledge the author's efforts in developing this valuable learning framework and look forward to seeing its continued evolution. To the authors and JOSE editor, I extend my gratitude for the opportunity to review this work. Please do not hesitate to reach out if you require further clarification or feedback. While I will happily review the reviewed version of this publication. SPECIFIC COMMENTS AVAILABLE HERE |
Dear @kls2177 |
Review checklist for @codyalbertrossConflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
|
Thank you for your patience with my review. Self-Guided Decision Support Groundwater Modelling with Python is a valuable contribution and satisfies a need for concise and informed guidance on PEST and pyEMU. I agree with @incsanchezro regarding the organization of the workbook and the effort put forward by the authors to develop and improve GMDSI. I found that the detail and theoretical background was exceptional and that the workbook followed a logical trajectory that is aligned with a typical workflow. Overall, I believe that this work is suitable for publication and that the authors seem ready to take feedback from end-users to continuously improve their experience. |
Thank you @incsanchezro and @codyalbertross for your time and effort on the reviews. We have addressed your comments and updated the repo and paper in the All the best, |
Hi @incsanchezro, thank you very much for your review. A technical request: can you please add your issues to the groundwater resource repo, not the JOSE repo? Please see the example that I provided above - if you click on the links in this example, you will notice that the links go to the resource repo. Thanks! |
Hi @kls2177, We have updated the repo in the |
Hi @rhugman, Thank you for responding to the reviewers feedback. I apologize for the delay. The next step is for your reviewers, @incsanchezro and @codyalbertross to respond to your revisions. I look forward to their feedback. There may be further revisions required. |
Hi @kls2177 , @incsanchezro and @codyalbertross, Any update on the response to revisions? Cheers, |
Hi @rhugman, sorry for the delay. I will follow-up with the reviewers by email. |
Hi @rhugman, to speed the process along, can you please provide links to your responses to the comments by reviews in the chat? Thanks! |
Hi @kls2177, thanks for expediting this. We responded to comments by @incsanchezro directly in the issues they raised (linked below): |
I have reviewed the author's response to comments and have also seen that several tweaks were made in response to a workshop. I think that all of the suggestions have been adequately resolved and recommend the paper for publication. |
Hi @rhugman, While we wait for any final comments from @incsanchezro, I have a few comments of my own.
Also, I recommend a quick grammatical/spell check of the paper. There are a couple of minor issues.
|
Thanks @kls2177,
As requested,:
Placed learning outcomes in special content block
I am not quite clear on what 3. and 4. refer to. Were these in regard to the GitHub Page? That page was very much out of date and has since been taken down. It was never part of the submitted paper. The only "website" that we maintain as part of this project is the git-hub repo.
Within the notebooks, where relevant we provide links to other specific notebooks. Please let me know if that addresses your concerns. Regards, |
Thanks @rhugman. The link to the notebooks is not working for me today. |
Hi @kls2177, as I mentioned in the previous post, that website was out of date and not intended as part of this submission. (Thank you for bringing to our attention that it was still live.) Apologies for any confusion this has caused - we missed that that was still there. I have removed reference to it from the repo's landing page. As is described in the README.md, the tutorials are intended to be cloned/downloaded and run locally. The compute requirements are too large to make it feasible to host up-to-date versions of the notebooks on GitHub. |
|
Addressed here. |
Hi @rhugman, the generated pdf is 8 pages long, which is much longer than typical JOSE papers. Although I feel the Content section should stay, some revision is required. I have made some suggested edits in a word doc (attached) in an attempt to consolidate and reduce the word count. Please let me know if you feel that these edits still capture the essence of what you intend for the paper. I felt that the "Statement of Need" and "Story of the Project" contained some repetitive and/or complementary material that could be consolidated. I have also removed the learning outcomes from the paper although I these should still be included in the repository. I have also made a few other smaller edits in an attempt to reduce the word count. Also, please check the references (see reference check above). Thanks for your patience! |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot set v1.0 as version |
Done! version is now v1.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/jose-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/jose-papers#151, then you can now move forward with accepting the submission by compiling again with the command |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
Folks, would you kindly double check everything according to our post-review checklist above? |
I see that the archive is at https://doi.org/10.5066/P901F9G0 on the ScienceBase catalog USGS repository. There, the title is "Parameter Estimation, Uncertainty Analysis, and Optimization with the PEST++ Family of codes: Tutorial Jupyter Notebooks"—but the title in the paper is "Self-Guided Decision Support Groundwater Modelling with Python." The author list also doesn't match. |
It looks like the ScienceBase landing page for the deposited item doesn't list a license. That's unfortunate… |
Hi @rhugman, please see Lorena's comments above. |
Apologies @labarba and @kls2177, my misunderstanding. Please see updated archive with current release, including license matching the repo: https://doi.org/10.5281/zenodo.13933751 The repo has been updated with a v1.0 release. Please let me know if I've missed anything else. Cheers, |
@editorialbot set 10.5281/zenodo.13933751 as archive |
Done! archive is now 10.5281/zenodo.13933751 |
@editorialbot set v1.0 as version |
Done! version is now v1.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/jose-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/jose-papers#155, then you can now move forward with accepting the submission by compiling again with the command |
Submitting author: @rhugman (Rui Hugman)
Repository: https://github.com/gmdsi/GMDSI_notebooks/
Branch with paper.md (empty if default branch): jose-review
Version: v1.0
Editor: @kls2177
Reviewers: @codyalbertross, @incsanchezro
Archive: 10.5281/zenodo.13933751
Paper kind: learning module
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@codyalbertross & @incsanchezro, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://openjournals.readthedocs.io/en/jose/reviewer_guidelines.html. Any questions/concerns please let @kls2177 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @codyalbertross
The text was updated successfully, but these errors were encountered: