Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: Satisfiability.jl: Satisfiability Modulo Theories in Julia #6550

Closed
editorialbot opened this issue Mar 28, 2024 · 47 comments
Closed

[PRE REVIEW]: Satisfiability.jl: Satisfiability Modulo Theories in Julia #6550

editorialbot opened this issue Mar 28, 2024 · 47 comments
Assignees
@dpsanders @diehlpk @rafaelbailo
Labels
Julia pre-review Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 28, 2024 •
edited
Loading

Submitting author: @elsoroka (Emiko Soroka)
Repository: https://github.com/elsoroka/Satisfiability.jl
Branch with paper.md (empty if default branch): joss-paper
Version: v0.1.1
Editor: @diehlpk
Reviewers: @rafaelbailo, @dpsanders, @computablee
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/68f75b3e24424e344dbb80af79dcab4b"><img src="https://joss.theoj.org/papers/68f75b3e24424e344dbb80af79dcab4b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/68f75b3e24424e344dbb80af79dcab4b/status.svg)](https://joss.theoj.org/papers/68f75b3e24424e344dbb80af79dcab4b)

Author instructions

Thanks for submitting your paper to JOSS @elsoroka. Currently, there isn't a JOSS editor assigned to your paper.

@elsoroka if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Mar 28, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1536.3 files/s, 144887.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           31            750           1116           2470
Markdown                        16            229              0            834
TeX                              6             35             29            369
Lisp                             3             63              0            310
YAML                             5              6             12            108
JSON                             1              0              0             30
Bourne Shell                     3              4              0             21
TOML                             2              4              0             14
Dockerfile                       1              2              0              7
-------------------------------------------------------------------------------
SUM:                            68           1093           1157           4163
-------------------------------------------------------------------------------

Commit count by author:

   231	Emiko Soroka
     2	dependabot[bot]
     1	Mykel Kochenderfer
     1	Thomas Schmelzer

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1299

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1410.4821 is OK
- 10.1007/s12532-023-00239-3 is OK
- 10.1145/1995376.1995394 is OK
- 10.1007/978-3-030-81688-9_9 is OK
- 10.1007/978-3-540-78800-3_24 is OK
- 10.3233/SAT190039 is OK
- 10.1038/d41586-019-02310-3 is OK
- 10.1109/TPDS.2018.2872064 is OK

MISSING DOIs

- No DOI given, and none found for title: The calculus of computation: decision procedures w...
- No DOI given, and none found for title: Decision procedures
- No DOI given, and none found for title: PySMT: a solver-agnostic library for fast prototyp...
- Entry without DOI or title found
- No DOI given, and none found for title: The SMT-LIB Standard: Version 2.6
- 10.1007/978-3-031-24950-1_5 may be a valid DOI for title: Satisfiability Modulo Custom Theories in Z3
- 10.1007/978-3-031-24950-1_12 may be a valid DOI for title: CosySEL: Improving SAT Solving Using Local Symmetr...
- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- Entry without DOI or title found
- No DOI given, and none found for title: The Satisfiability Modulo Theories Library (SMT-LI...
- 10.1007/978-3-030-80223-3_26 may be a valid DOI for title: SMT-switch: a solver-agnostic C++ API for SMT solv...

INVALID DOIs

- 10.1007/978-3-030-99524-9\_24 URL is INVALID
- 3136000.3136004 is INVALID
- https://doi.org/10.1016/j.cosrev.2020.100254 is INVALID because of 'https://doi.org/' prefix

@danielskatz
Copy link

👋 @elsoroka - thanks for your submission. I'll next work on finding an editor.

While I do so, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Also please fix the invalid DOIs. Make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

👋 @hugoledoux - do you think you could edit this submission?

@danielskatz
Copy link

@editorialbot invite @hugoledoux as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@hugoledoux
Copy link

@danielskatz a bit difficult: I am starting my holidays today

@danielskatz
Copy link

👋 @diehlpk - Are you able to take one more submission to edit?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Mar 29, 2024

@editorialbot add @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@diehlpk
Copy link
Member

diehlpk commented Mar 29, 2024 •
edited
Loading

@danielskatz I can take this one but I will start late next week due to a long weekend.

@danielskatz
Copy link

Thanks!

@elsoroka
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1410.4821 is OK
- 10.1007/s12532-023-00239-3 is OK
- 10.1145/1995376.1995394 is OK
- 10.1007/978-3-030-81688-9_9 is OK
- 10.1007/978-3-540-78800-3_24 is OK
- 10.3233/SAT190039 is OK
- 10.1038/d41586-019-02310-3 is OK
- 10.1109/TPDS.2018.2872064 is OK

MISSING DOIs

- No DOI given, and none found for title: The calculus of computation: decision procedures w...
- No DOI given, and none found for title: Decision procedures
- No DOI given, and none found for title: PySMT: a solver-agnostic library for fast prototyp...
- Entry without DOI or title found
- No DOI given, and none found for title: The SMT-LIB Standard: Version 2.6
- 10.1007/978-3-031-24950-1_5 may be a valid DOI for title: Satisfiability Modulo Custom Theories in Z3
- 10.1007/978-3-031-24950-1_12 may be a valid DOI for title: CosySEL: Improving SAT Solving Using Local Symmetr...
- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- Entry without DOI or title found
- No DOI given, and none found for title: The Satisfiability Modulo Theories Library (SMT-LI...
- 10.1007/978-3-030-80223-3_26 may be a valid DOI for title: SMT-switch: a solver-agnostic C++ API for SMT solv...

INVALID DOIs

- 10.1007/978-3-030-99524-9\_24 URL is INVALID
- 3136000.3136004 is INVALID
- https://doi.org/10.1016/j.cosrev.2020.100254 is INVALID because of 'https://doi.org/' prefix

@elsoroka
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1410.4821 is OK
- 10.1007/s12532-023-00239-3 is OK
- 10.1145/1995376.1995394 is OK
- 10.1007/978-3-030-81688-9_9 is OK
- 10.1007/978-3-540-78800-3_24 is OK
- 10.1007/978-3-030-99524-9_24 is OK
- 10.3233/SAT190039 is OK
- 10.1145/3136000.3136004 is OK
- 10.1007/978-3-031-24950-1_5 is OK
- 10.1007/978-3-031-24950-1_12 is OK
- 10.1137/141000671 is OK
- 10.1007/978-3-030-80223-3_26 is OK

MISSING DOIs

- No DOI given, and none found for title: The calculus of computation: decision procedures w...
- No DOI given, and none found for title: Decision procedures
- No DOI given, and none found for title: PySMT: a solver-agnostic library for fast prototyp...
- No DOI given, and none found for title: PicoSAT.jl
- No DOI given, and none found for title: The SMT-LIB Standard: Version 2.6

INVALID DOIs

- None

@elsoroka
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@diehlpk
Copy link
Member

diehlpk commented Apr 9, 2024

Hi @elsoroka could you please suggest reviewers?

@diehlpk
Copy link
Member

diehlpk commented Apr 9, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @diehlpk, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@diehlpk
Copy link
Member

diehlpk commented Apr 9, 2024

Hi @rafaelbailo do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Apr 9, 2024

Hi @ggmirandac do you have time to review the paper?

@rafaelbailo
Copy link

Hi @diehlpk , I do have time to review, but I don't know if I'm the right person! This is the first time I'm hearing the words "satisfiability modulo theories", so my input might not be so helpful...

@diehlpk
Copy link
Member

diehlpk commented Apr 12, 2024

Hi @diehlpk , I do have time to review, but I don't know if I'm the right person! This is the first time I'm hearing the words "satisfiability modulo theories", so my input might not be so helpful...

I think your input one the code quality, installation process, and documentation would be very helpful.

@diehlpk
Copy link
Member

diehlpk commented Apr 12, 2024

@editorialbot add @rafaelbailo as reviewer

@editorialbot
Copy link
Collaborator Author

@rafaelbailo added to the reviewers list!

@elsoroka
Copy link

@diehlpk, @mykelk suggested this list of people who have contributed to SMT projects in GitHub as potential reviewers.

https://github.com/marcogario
https://github.com/mikand
https://github.com/NikolajBjorner
https://github.com/wintersteiger
https://github.com/ajreynol
https://github.com/aniemetz

@diehlpk
Copy link
Member

diehlpk commented Apr 16, 2024

Hi @marcogario do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Apr 16, 2024

Hi @mikand do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Apr 16, 2024

Hi @NikolajBjorner do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented May 6, 2024

Hi @wintersteiger do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented May 6, 2024

Hi @ajreynol do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented May 6, 2024

Hi @aniemetz do you have time to review this paper?

@dpsanders
Copy link

dpsanders commented May 16, 2024 •
edited
Loading

I can review this. I have Julia knowledge and some domain knowledge.

@diehlpk
Copy link
Member

diehlpk commented May 16, 2024

@editorialbot add @dpsanders as reviewer

@editorialbot
Copy link
Collaborator Author

@dpsanders added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented May 16, 2024

@editorialbot add @computablee as reviewer

@editorialbot
Copy link
Collaborator Author

@computablee added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented May 16, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpsanders dpsanders

@diehlpk diehlpk

@rafaelbailo rafaelbailo

Labels
Julia pre-review Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dpsanders @hugoledoux @danielskatz @diehlpk @elsoroka @rafaelbailo @editorialbot