Support patchPodTemplateMetadata when enableExtraWorkloadForCanary = false

[PersistentJZH]

Hi masters, Currently patchPodTemplateMetadata will only take effect when enableExtraWorkloadForCanary = true. Whether to consider also supporting patchPodTemplateMetadata when enableExtraWorkloadForCanary = false.

Background: We use kruise rollout for canary release, and distinguish canary pods through pod labels. For some reason, we need to set enableExtraWorkloadForCanary to false, so we want to add some labels to the canary pod through patchPodTemplateMetadata in this case.

[furykerry]

what do you need for the extra label of canary pods, if you just want to find the canary pods, you can set order id (rollouts.kruise.io/rollout-id) in workload and the pod will be patch with batch id(rollouts.kruise.io/rollout-batch-id)

[PersistentJZH]

ok thanks. Due to architectural historical reasons, our service discovery distinguishes canary pods by identifying the label of the pod (version=canary). And our PaaS Release Platform supports choosing whether to enableExtraWorkloadForCanary before release, which requires a unified method to label pod (use rollouts.kruise.io/rollout-id uniformly or use patchPodTemplateMetadata uniformly.).

Here are one questions to confirm:

Will rollouts.kruise.io/rollout-id take effect when enableExtraWorkloadForCanary=true?

[furykerry]

rollouts.kruise.io/rollout-id currently only works for case enableExtraWorkloadForCanary=true.

[furykerry]

@PersistentJZH can you attend the biweekly meeting tonight, we can have a discuss about the support of patchPodTemplateMetadata when enableExtraWorkloadForCanary = false

[PersistentJZH]

sure, I will attend on time. thanks.