Skip to content

Commit 17a4441

Browse files
committed
feat: implement config service retreaving service providers data
1 parent fc5bad5 commit 17a4441

File tree

5 files changed

+5
-81
lines changed

5 files changed

+5
-81
lines changed

src/assets/ora-logo.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/assets/ora-mark.svg

Lines changed: 0 additions & 49 deletions
This file was deleted.

src/lib/model/portal-config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ export interface EntityConfig {
1515
export interface PortalConfig {
1616
providers: ServiceProvider[];
1717
tenantId: string;
18-
frameContext: Record<string, any>;
18+
portalContext: Record<string, any>;
1919
featureToggles: Record<string, boolean>;
2020
}

src/lib/services/luigi-config/static-settings-config.service.spec.ts

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,17 @@ import { LuigiCoreService } from '../luigi-core.service';
33

44
describe('StaticSettingsConfigServiceImpl', () => {
55
let service: StaticSettingsConfigServiceImpl;
6-
let luigiCoreServiceMock: jest.Mocked<LuigiCoreService>;
76

87
beforeEach(() => {
9-
luigiCoreServiceMock = {
10-
isFeatureToggleActive: jest.fn(),
11-
} as unknown as jest.Mocked<LuigiCoreService>;
12-
13-
service = new StaticSettingsConfigServiceImpl(luigiCoreServiceMock);
8+
service = new StaticSettingsConfigServiceImpl();
149
});
1510

1611
it('should be created', () => {
1712
expect(service).toBeTruthy();
1813
});
1914

2015
describe('getInitialStaticSettingsConfig', () => {
21-
it('should return the correct configuration with MFP logo when feature toggle is active', () => {
22-
luigiCoreServiceMock.isFeatureToggleActive.mockReturnValue(true);
23-
16+
it('should return the correct configuration with MFP logo', () => {
2417
const config = service.getInitialStaticSettingsConfig();
2518

2619
expect(config).toEqual({
@@ -41,23 +34,6 @@ describe('StaticSettingsConfigServiceImpl', () => {
4134
hideAutomatically: true,
4235
},
4336
});
44-
45-
expect(luigiCoreServiceMock.isFeatureToggleActive).toHaveBeenCalledWith(
46-
'mfp-logo'
47-
);
48-
});
49-
50-
it('should return the correct configuration with ORA logo when feature toggle is inactive', () => {
51-
luigiCoreServiceMock.isFeatureToggleActive.mockReturnValue(false);
52-
53-
const config = service.getInitialStaticSettingsConfig();
54-
55-
expect(config.header.logo).toBe('assets/ora-mark.svg');
56-
expect(config.header.favicon).toBe('assets/ora-mark.svg');
57-
58-
expect(luigiCoreServiceMock.isFeatureToggleActive).toHaveBeenCalledWith(
59-
'mfp-logo'
60-
);
6137
});
6238
});
6339

src/lib/services/luigi-config/static-settings-config.service.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,10 @@ export interface StaticSettingsConfigService {
1212
export class StaticSettingsConfigServiceImpl
1313
implements StaticSettingsConfigService
1414
{
15-
constructor(private luigiCoreService: LuigiCoreService) {}
15+
constructor() {}
1616

1717
getInitialStaticSettingsConfig() {
18-
const logo = this.luigiCoreService.isFeatureToggleActive('mfp-logo')
19-
? 'assets/mfp_mark.svg'
20-
: 'assets/ora-mark.svg';
18+
const logo = 'assets/mfp_mark.svg';
2119

2220
return {
2321
header: {

0 commit comments

Comments
 (0)