Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of fixes for failing test cases #199

Open
zhang-ivy opened this issue Mar 5, 2020 · 2 comments
Open

List of fixes for failing test cases #199

zhang-ivy opened this issue Mar 5, 2020 · 2 comments

Comments

@zhang-ivy
Copy link
Contributor

Here are the issues/fixes we discussed:

  1. Wrong stereochemistry and clashes
  • Fix: Add restraints
  • Check atom and bond stereochemistry is biologically correct
  • Also check for bad bond lengths/angles and atom clashes?
  1. Truncate and cap terminal and internal loops
  • Fix: Allow user to specify options OR edit fixer.missingResidues dictionary
  1. Missing SEQRES
  • Fix: Add warning when the PDB is missing SEQRES lines

TO DO: prepare list of test cases (PDB ids)
@jchodera @peastman @rafwiewiora

@peastman
Copy link
Member

peastman commented Mar 6, 2020

Fix: Add warning when the PDB is missing SEQRES lines

Should it always warn about this, or only if there are gaps in the residue numbers? If all residues in each chain have sequential numbers we know there can't be any missing loops in the middle, though of course we can't rule out missing terminal residues.

@rafwiewiora
Copy link

Should it always warn about this, or only if there are gaps in the residue numbers? If all residues in each chain have sequential numbers we know there can't be any missing loops in the middle, though of course we can't rule out missing terminal residues.

But what if you've used some tool that resets the residue numbers to sequential? I'd say always warn, better safe than sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants