Skip to content

Failing e2e tests "Revalidate path" but CI is still green #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vicb opened this issue Mar 20, 2025 · 1 comment
Open

Failing e2e tests "Revalidate path" but CI is still green #477

vicb opened this issue Mar 20, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@vicb
Copy link
Contributor

vicb commented Mar 20, 2025

There is a failure in the e2e tests:

examples/e2e/app-router e2e:   1) [chromium] › e2e/revalidateTag.test.ts:71:5 › Revalidate path ─────────────────────────────────
examples/e2e/app-router e2e:     Error: expect(received).not.toEqual(expected) // deep equality
examples/e2e/app-router e2e:     Expected: not "RequestID: CB7VRMZdJEi4c8sGAg1CVBilvBE3BiPhfkyMddU43MjaXJsaXURJ6A=="
examples/e2e/app-router e2e:       90 |   elLayout = page.getByText("RequestID:");
examples/e2e/app-router e2e:       91 |   const newReqId = await elLayout.textContent();
examples/e2e/app-router e2e:     > 92 |   expect(newReqId).not.toEqual(initialReqId);
examples/e2e/app-router e2e:          |                        ^
examples/e2e/app-router e2e:       93 |
examples/e2e/app-router e2e:       94 |   elLayout = page.getByText("Date:");
examples/e2e/app-router e2e:       95 |   const newDate = await elLayout.textContent();
examples/e2e/app-router e2e:         at /home/runner/work/opennextjs-cloudflare/opennextjs-cloudflare/examples/e2e/app-router/e2e/revalidateTag.test.ts:92:24

I can see it both locally and on the CI -> We should fix the CI to report a correct status

@vicb vicb added the bug Something isn't working label Mar 20, 2025
@conico974
Copy link
Collaborator

Ho yeah, i'm a bit silly. This one will likely fail from time to time in CI because of this

tagCache: shardedTagCache({ numberOfShards: 12, regionalCache: true }),

There is a 5 second regional cache for the tag cache....
We need to either wait for the regional cache to expire, or just remove it entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants