You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if the adapter should warn or even error when it detects that some unsupported packages are being used.
Ideally we should have a check that:
checks the current package.json (or whatever makes more sense)
if it doesn't find any problematic package nothing happens
if it does fine a package which we have issues with it checks its version
if the version is in the range we have problems with (after a version the package could have been fixed for example)
if the issues we have with the package are not critical (something doesn't work perfectly but it doesn't introduce huge issues) than a warning is shown
if the issues we have with the package are critical (it not working properly for example can introduce vulnerability risks) then an error should actually be thrown stopping the build
The warning/error should also point to a page to the docs, or maybe a sub-page of https://opennext.js.org/cloudflare/known-issues where we have a list of the problematic packages where the issues are clearly explained to users
Note
I am not sure if the erroring bit could be a bit overkill and warnings should generally do? 🤔
(because if we have false positives in the check this could be really really annoying to users)
@opennextjs/cloudflare version
1.0.0-beta.0
Before submitting
I have checked that there isn't already a similar feature request
This is a single feature (not multiple features in one request)
The text was updated successfully, but these errors were encountered:
An example of a package that would get such a warning is next-themes (#511) (hopefully we can fix the issue upstream, thus why the version check could be applied not to show the warning for future versions of the package 🙂🤞)
It would be nice if the adapter should warn or even error when it detects that some unsupported packages are being used.
Ideally we should have a check that:
The warning/error should also point to a page to the docs, or maybe a sub-page of https://opennext.js.org/cloudflare/known-issues where we have a list of the problematic packages where the issues are clearly explained to users
Note
I am not sure if the erroring bit could be a bit overkill and warnings should generally do? 🤔
(because if we have false positives in the check this could be really really annoying to users)
@opennextjs/cloudflare version
1.0.0-beta.0
Before submitting
The text was updated successfully, but these errors were encountered: