Remove globally assigned mime type for text/javascript (#129)

* remove globally asigned mime type

* add rake task

* apply review suggestion

* fix readme

---------

Co-authored-by: Ivan Vergés <[email protected]>

Author: ElviaBth

README.md

@@ -51,6 +51,20 @@ Depending on your Decidim version, you can choose the corresponding version to e
 | 0.4.x   | 0.29.x                      |
 
 
+## Required MIME types
+
+Latests versions of PDFjs require that the web server to send the mime type `text/javascript` for files ending in `.mjs`
+
+### Usage with Puma + Rack
+
+If you are using Puma with Rack (< v3.1.0) you might have to add and initializer to ensure files with `.mjs` are served correctly. This is usually the most common approach when docker is used or when the ENV var `RAILS_SERVE_STATIC_FILES=true` is active.
+
+Execute the following command to create an initializer that does that:
+
+```
+bin/rails decidim_participatory_documents:install_mjs_initializer
+```
+
 ### Usage with external static file servers
 
 A common setup is to use standalone web server (such as Nginx or Apache) to serve the static files present in the `public` folder.

Rakefile

@@ -9,6 +9,7 @@ def install_module(path)
     system("bundle exec rake decidim_participatory_documents:install:migrations")
     system("bundle exec rake db:migrate")
     system("bundle exec rake decidim_participatory_documents:install_pdf_js")
+    system("bundle exec rake decidim_participatory_documents:install_mjs_initializer")
   end
 end
 

lib/decidim/participatory_documents/engine.rb

@@ -32,12 +32,6 @@ class Engine < ::Rails::Engine
         Rails.logger.error("Error while trying to include Decidim::ReportingProposals::ParticipatorySpaceUserRoleOverride: #{e.message}")
       end
 
-      # Older versions of Rack does not support the .mjs extension, so we register it here.
-      initializer "decidim_participatory_documents.rack_mime" do
-        Mime::Type.register "text/javascript", :mjs
-        Rack::Mime::MIME_TYPES[".mjs"] = "text/javascript"
-      end
-
       initializer "decidim_participatory_documents.overrides", after: "decidim.action_controller" do
         config.to_prepare do
           Decidim::ParticipatorySpaceRoleConfig::Valuator.include(Decidim::ParticipatoryDocuments::ValuatorOverride)

lib/tasks/decidim_participatory_documents.rake

@@ -8,6 +8,25 @@ namespace :decidim_participatory_documents do
     apply_path_corrections_to_pdfjs "public"
   end
 
+  # Since older versions of Rack does not support the .mjs extension, so we register it here."
+  desc "Create rack mime type initializer for .mjs files"
+  task :install_mjs_initializer do
+    initializer_path = Rails.root.join("config/initializers/rack_mjs_type.rb")
+
+    if File.exist?(initializer_path)
+      puts "⚠️ Initializer already exists at #{initializer_path}, skipping creation."
+      next
+    end
+
+    content = <<~RUBY
+      Mime::Type.register "text/javascript", :mjs
+      Rack::Mime::MIME_TYPES[".mjs"] = "text/javascript"
+    RUBY
+
+    File.write(initializer_path, content)
+    puts "Created initializer at #{initializer_path}"
+  end
+
   private
 
   def decidim_participatory_documents_path
@@ -63,6 +82,7 @@ end
 
 Rake::Task["decidim:upgrade:webpacker"].enhance do
   Rake::Task["decidim_participatory_documents:install_pdf_js"].invoke
+  Rake::Task["decidim_participatory_documents:create_mjs_initializer"].invoke
 end
 
 Rake::Task["decidim:choose_target_plugins"].enhance do