Skip to content

Avoid using regexps always #80

Open
@gsmet

Description

@gsmet

@ammachado in the configuration properties recipes, we say that the elements can be regexp but in fact they always are, right?

So if you want to replace quarkus.something key, you actually need to define quarkus\.something or you will also replace quarkuswsomethingor quarkus-something.

This makes things a bit more complex than they need to be and also not in line with https://docs.openrewrite.org/recipes/properties/changepropertykey where you have this regex boolean to actually enable regexp transformation.

I wonder if we should change the current behavior to avoid regexps in the default case and only enable regexps when regex is set to true.

That would be a breaking change but I think these recipes are new enough that it's worth breaking them to be consistent with the rest of OpenRewrite.

I thought about that because I was migrating old Quarkus Update recipes to this new stuff.

WDYT?

/cc @timtebeek for advice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions