Enable custom start commands and options to resolve GHA issues #676
Conversation
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
Bukhtawar,
bharath-techie,
Arpit-Bandejiya,
RS146BIJAY,
pranikum,
mch2,
andrross,
kotwanikunal,
Rishikesh1159 and
finnegancarroll
as code owners
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
|
Hi @finnegancarroll @cwperks please take a look on this. Thanks. |
|
Should we also update actions/setup-java to v4? |
This particular PR is just to update previously failed and unsupported upload artifact actions. Thanks. |
Sounds good, just mentioned cause I think I faced some node issue for the setup-java upgrades. Not a maintainer on this repo but updating on a different PR sounds good |
There was a problem hiding this comment.
Thank you @peterzhuamazon! This PR looks good to me. I'm not a maintainer of this repo so a maintainer should also have a look.
| @@ -30,16 +30,11 @@ jobs: | |||
| # this image tag is subject to change as more dependencies and updates will arrive over time | |||
| image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }} | |||
| # need to switch to root so that github actions can install runner binary on container without permission issues. | |||
There was a problem hiding this comment.
nit: remove this comment since the line below it is getting removed in this PR
Description
Enable custom start commands and options to resolve GHA issues
Related Issues
Closes #666 #673
opensearch-project/opensearch-build#5178
Check List
[ ] New functionality includes testing.[ ] New functionality has been documented.[ ] API changes companion pull request created.--signoff.[ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.