context consistency: ensure all context are TODO()

Author: sebrandon1

pkg/controller/deployment/deployment_helper_test.go

@@ -334,7 +334,7 @@ func TestGetOverrideResourcesFor(t *testing.T) {
 		},
 	}
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.TODO())
 	defer cancel()
 
 	// Create channel to know when the watch has started.
@@ -856,7 +856,7 @@ func TestGetOverrideSchedulingFor(t *testing.T) {
 		},
 	}
 
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.TODO())
 	defer cancel()
 
 	// Create channel to know when the watch has started.

pkg/controller/istiocsr/certificates_test.go

@@ -217,7 +217,7 @@ func TestCreateOrApplyCertificates(t *testing.T) {
 			}
 			r.ctrlClient = mock
 			istiocsr := &v1alpha1.IstioCSR{}
-			if err := r.Get(context.Background(), types.NamespacedName{
+			if err := r.Get(context.TODO(), types.NamespacedName{
 				Namespace: testIstioCSR().Namespace,
 				Name:      testIstioCSR().Name,
 			}, istiocsr); err != nil {

pkg/controller/istiocsr/controller.go

@@ -64,7 +64,7 @@ func New(mgr ctrl.Manager) (*Reconciler, error) {
 	}
 	return &Reconciler{
 		ctrlClient:    c,
-		ctx:           context.Background(),
+		ctx:           context.TODO(),
 		eventRecorder: mgr.GetEventRecorderFor(ControllerName),
 		log:           ctrl.Log.WithName(ControllerName),
 		scheme:        mgr.GetScheme(),
@@ -111,43 +111,43 @@ func BuildCustomClient(mgr ctrl.Manager) (client.Client, error) {
 	if err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &v1alpha1.IstioCSR{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &v1alpha1.IstioCSR{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &certmanagerv1.Certificate{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &certmanagerv1.Certificate{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &appsv1.Deployment{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &appsv1.Deployment{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &rbacv1.ClusterRole{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &rbacv1.ClusterRole{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &rbacv1.ClusterRoleBinding{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &rbacv1.ClusterRoleBinding{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &rbacv1.Role{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &rbacv1.Role{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &rbacv1.RoleBinding{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &rbacv1.RoleBinding{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &corev1.Service{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &corev1.Service{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &corev1.ServiceAccount{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &corev1.ServiceAccount{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &corev1.Secret{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &corev1.Secret{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &corev1.ConfigMap{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &corev1.ConfigMap{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &certmanagerv1.Issuer{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &certmanagerv1.Issuer{}); err != nil {
 		return nil, err
 	}
-	if _, err = customCache.GetInformer(context.Background(), &certmanagerv1.ClusterIssuer{}); err != nil {
+	if _, err = customCache.GetInformer(context.TODO(), &certmanagerv1.ClusterIssuer{}); err != nil {
 		return nil, err
 	}
 

pkg/controller/istiocsr/controller_test.go

@@ -390,7 +390,7 @@ func TestReconcile(t *testing.T) {
 			}
 			r.ctrlClient = mock
 			istiocsr := testIstioCSR()
-			result, err := r.Reconcile(context.Background(),
+			result, err := r.Reconcile(context.TODO(),
 				ctrl.Request{
 					NamespacedName: types.NamespacedName{Name: istiocsr.GetName(), Namespace: istiocsr.GetNamespace()},
 				},

pkg/controller/istiocsr/test_utils.go

@@ -36,7 +36,7 @@ var (
 
 func testReconciler(t *testing.T) *Reconciler {
 	return &Reconciler{
-		ctx:           context.Background(),
+		ctx:           context.TODO(),
 		eventRecorder: record.NewFakeRecorder(100),
 		log:           testr.New(t),
 		scheme:        library.Scheme,