Skip to content

get rid of ./lib/* fork #819

@runcom

Description

@runcom

This somehow depends on #588 but can be done w/o that finished as well. Code under ./lib is basically a fork of an old project that now fully lives in openshift/library-go.

We need to:

  • Fix move types to openshift/api #588 (but again, this issue can be done 99% w/o that)
  • Move existing code to use openshift/library-go/pkg/operator/resource/* for core types
  • drop ./lib

As of today, since #588 isn't done yet, we can work on the second point above as follows:

  • Move existing code to use openshift/library-go/pkg/operator/resource/* for core types (instead of our ./lib/resource* packages)
  • leave under ./lib just ./lib/*/machineconfig* files, types and funcs since we still need those till move types to openshift/api #588 is done
  • while removing funcs from the above, contribute any core func to library-go as well (if any, haven't checked).

Example:

Move

_, updated, err := resourceapply.ApplyCustomResourceDefinition(optr.apiExtClient.ApiextensionsV1beta1(), c)
to https://github.com/openshift/library-go/blob/master/pkg/operator/resource/resourceapply/apiextensions.go#L32 (applies for resourceread package and the others as well in the surrounding lines)

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions