Fix multiple *:wikipedia links

[Oivo35]

URL

https://www.openstreetmap.org/node/5328066229#map=19/55.155481/8.773159

How to reproduce the issue?

There is issue with displaying of
multiple subject:wikipedia links
https://www.openstreetmap.org/node/5328066229

Same with brand:wikipedia
https://www.openstreetmap.org/node/373744329

operator:wikipedia
https://www.openstreetmap.org/node/5167657812

And probably other *:wikipedia tags.

Screenshot(s) or anything else?

No response

[tomhughes]

Well that just means somebody has put bad data in the database so feel free to fix it.

[Oivo35]

@tomhughes
Data and format are correct. Both wikipedia links exist
https://da.wikipedia.org/wiki/Genforeningen_i_1920
https://da.wikipedia.org/wiki/Bes%C3%A6ttelsen

But osm website doesn't know that these are two separate items.

[tomhughes]

I thought you were complaining about the broken link?

[tomhughes]

Oh I see you've tried to put a semicolon separated list of values but we're treating it as a single value? Has that ever worked?

[Oivo35]

Oh I see you've tried to put a semicolon separated list of values but we're treating it as a single value? Has that ever worked?

Yes, multiple subject:wikidata links work with semicolon, but subject:wikipedia or other *:wikipedia links don't. This feature would be new. Now only one *:wikipedia link works.

[pablobm]

On quick investigation, this seems to be handled by app/helpers/browse_tags_helper.rb. The method wikidata_links is aware of semicolons (code), but wikipedia_links is not.

Are these tags (subject:wikipedia and generally *:wikipedia) expected to allow multiple values?

• In favour:
  • It would make sense as this instance is trying to link to exactly the same subjects as the Wikidata links, just in their Wikipedia forms.
• Against:
  • As per https://wiki.openstreetmap.org/wiki/Key:wikipedia#Secondary_languages: "In almost all cases, a single wikipedia tag using the primary language for the subject, as described above, is sufficient". In contrast, at https://wiki.openstreetmap.org/wiki/Key:wikidata#Secondary_Wikidata_links we see "In some rare cases where the subject is plural, values will be separated by a semicolon". Neither wording is definitive, with "almost all cases" and "in some rare cases", but only the Wikidata one mentions semicolons.
  • In this specific example, the first link seems relevant ("Schleswig plebiscite"), while I'm not sure that the second one is ("Denmark in World War II").

This seems rare indeed, with only 107 instances of multiple values for subject:wikipedia as I write these lines.