Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: configured CryptoProvider enhancements/hardening #1183

Open
jakedoublev opened this issue Jul 19, 2024 · 5 comments
Open

Epic: configured CryptoProvider enhancements/hardening #1183

jakedoublev opened this issue Jul 19, 2024 · 5 comments
Assignees
Labels
comp:core Core component comp:kas Key Access Server

Comments

@jakedoublev
Copy link
Contributor

Background

At present, the server.cryptoProvider in the platform config is used primarily for management of KAS keys. However, the platform engages with other sensitive cryptographic and crypto-adjacent materials (keys of varied types for other services, tokens, TLS certs, HSM information, etc).

Rather than spreading configuration of varying crypto-related values across the service configs, we should enhance and centralize the cryptoProvider config interface to make it extensible to n number of keys and key types across n number of services, and let each service do its own validation/panic that it has the cryptographic material it requires.

Centralizing sensitive config will make administration of a platform and development on top of it both easier.

Acceptance Criteria

TODO

@jakedoublev jakedoublev added comp:core Core component comp:kas Key Access Server labels Jul 19, 2024
@jrschumacher
Copy link
Member

@dmihalcik-virtru Jake and I were discussing how an admin would manage the cryptoprovider when we look at supporting clickops. Currently, they would have to update the config or update the Envs.

Do you have any thoughts about this you'd like to add?

@jakedoublev
Copy link
Contributor Author

Related to #1254

@github-actions github-actions bot added the Stale label Dec 5, 2024
@jrschumacher
Copy link
Member

@jakedoublev @strantalis @dmihalcik-virtru let's collaborate on this. We're seeing a number of areas where we need key material apart from KAS. It seems that cryptoprovider needs to be part of the core to support the various usecases.

@jakedoublev
Copy link
Contributor Author

@jrschumacher It looks like @dmihalcik-virtru did some work around this in the past few weeks: #1834

@dmihalcik-virtru
Copy link
Member

yes, I have a modified version of the cryptoprovider config in the branch that is referenced above. I'm putting it on hold until after Sean's work with the new key table and my work with ECC for TDF land

@github-actions github-actions bot removed the Stale label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:core Core component comp:kas Key Access Server
Projects
None yet
Development

No branches or pull requests

4 participants