Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy: KAS registry remote public key should permit a port number within the remote key URI #1775

Open
jakedoublev opened this issue Nov 20, 2024 · 0 comments

Comments

@jakedoublev
Copy link
Contributor

This line of regex denies a port number in a registered KAS's remote public key URI: https://github.com/opentdf/platform/blob/main/service/policy/objects.proto#L302

This should be valid: https://local.com:8080/kas/v2/kas_public_key but instead gives:

public_key.remote: URI must be a valid URL (e.g., 'https://demo.com/') followed by additional segments. Each segment must start and end with an alphanumeric character, can contain hyphens, alphanumeric characters, and slashes. [uri_format]

Acceptance Criteria

  1. consider if this.isUri() is a better CEL validator for this need
  2. port numbers are allowed
  3. unit tests added to proto validation for this scenario:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant