Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forge] Core Price Bug #2908

Open
3 of 5 tasks
Peixonauta2 opened this issue Sep 24, 2024 · 0 comments
Open
3 of 5 tasks

[Forge] Core Price Bug #2908

Peixonauta2 opened this issue Sep 24, 2024 · 0 comments
Labels
Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Peixonauta2
Copy link
Contributor

Peixonauta2 commented Sep 24, 2024

Priority

High

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

I'm using the main branch.

It seems that the current way of dealing with exalted forge core prices for transfering tiers (non-convergence and convergence) is a bit off.

The code, as far as I investigated, isn't prepared to read the core prices the way it should:

  • If I'm trying to transfer a tier 10 without the convergence switch activated, the core price will be incorrect (1 tier lower than it should be, 9)
  • If I'm trying to transfer a tier 10 with the convergence switch activated, the core price will be correct

The problem is: the client allows the players to start the transfer (even if they don't have the number of cores needed for the transfer) because the information that is sent to the client is wrong. As the player does not have the number of cores that the server expects, an error message appears and the items are removed.

https://s11.gifyu.com/images/SAQeF.gif

As you can see, the first tentative, I've transfered the tier from the cobra hood to the golden helmet. The client asked for 60 cores, but the server was expecting to remove 85.

image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Peixonauta2 Peixonauta2 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Sep 24, 2024
@github-actions github-actions bot added Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

1 participant