Skip to content

Error in overlapping service days #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t2gran opened this issue May 19, 2025 · 1 comment · May be fixed by #6666
Open

Error in overlapping service days #6664

t2gran opened this issue May 19, 2025 · 1 comment · May be fixed by #6666
Assignees

Comments

@t2gran
Copy link
Member

t2gran commented May 19, 2025

Expected behavior

Trips throughout the day may start from the first stop 24h ++ past midnight. This is common for "night-buses" witch is designed to run together with the services of the previous day. If the service for the next day start up early, before the last departure of the previous day, then OTP does not handle this correct.

Example
Departure times from Majorstua(first stop):

Monday : ... 19:35 20:35  27:35(03:35)
Tuesday : 02:35 04:05 04:35 05:05 05:35 ... 

The 27:35 departure is AFTER the first departure 02:35 on Tuesday.

When doing trip searches we expect all departures to be available, but the Tuesday 02:35 does not show up - it is skipped in the timetable view:

Image

Version of OTP used (exact commit hash or JAR name)

dev-2.x

Data sets in use (links to GTFS and OSM PBF files)

https://developer.entur.org/stops-and-timetable-data

Only the NBU dataset is required to reproduce the problem.

@t2gran
Copy link
Member Author

t2gran commented May 19, 2025

The reason why this happen is an error in the TripPatternForDates witch build up a "timetable" by concatenating the trip times for each day.

@t2gran t2gran self-assigned this May 19, 2025
@t2gran t2gran linked a pull request May 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant