Skip to content

Commit cd3571b

Browse files
authored
Merge pull request #16 from servicetitan/master
fix: remove tarballs on package removal
2 parents b78185a + f0065b1 commit cd3571b

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/PackageStorage.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,17 @@ export default class StoragePluginManager implements ILocalPackageManager {
4242
}
4343

4444
public deletePackage(fileName: string, callback: CallbackAction): void {
45+
if (fileName.toLowerCase().endsWith('.tgz')) {
46+
return this.tarballPackageStorage.deletePackage(fileName, callback);
47+
}
48+
4549
return this.packumentPackageStorage.deletePackage(fileName, callback);
4650
}
4751

4852
public removePackage(callback: CallbackAction): void {
49-
return this.packumentPackageStorage.removePackage(callback);
53+
return this.packumentPackageStorage.removePackage(() => {
54+
this.tarballPackageStorage.removePackage(callback);
55+
});
5056
}
5157

5258
public createPackage(name: string, data: Package, callback: CallbackAction): void {

tests/plugin.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ describe('verdaccio-storage-proxy', () => {
149149
test('removePackage', () => {
150150
const cb = jest.fn();
151151
packageStorage.removePackage(cb);
152-
expect(packageStorage.packumentPackageStorage.removePackage).toHaveBeenCalledWith(cb);
152+
expect(packageStorage.packumentPackageStorage.removePackage).toHaveBeenCalled();
153153
});
154154
test('deletePackage', () => {
155155
const cb = jest.fn();

0 commit comments

Comments
 (0)