-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error installing node-postal #24
Comments
There is a pending PR to get Node.js v12+ compatibility in. Hopefully, it'll get merged soon. In the meantime, I forked to here with the PR merged: https://www.npmjs.com/package/@cymen/node-postal This definitely works with Node.js v12 and should work with v13. |
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between [node-postal and Node.js 12](openvenues/node-postal#24). We are now using a Node.js 12 compatible fork of the `node-postal` libary, so we can now bring the libpostal baseimage back to parity with the other Docker images. This will reduce complexity, maintenance times, and download sizes for Pelias containers.
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between [node-postal and Node.js 12](openvenues/node-postal#24). We are now using a Node.js 12 compatible fork of the `node-postal` libary, so we can now bring the libpostal baseimage back to parity with the other Docker images. This will reduce complexity, maintenance times, and download sizes for Pelias containers. Connects pelias/interpolation#245 Connects pelias/pelias#800
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between [node-postal and Node.js 12](openvenues/node-postal#24). We are now using a Node.js 12 compatible fork of the `node-postal` libary, so we can now bring the libpostal baseimage back to parity with the other Docker images. This will reduce complexity, maintenance times, and download sizes for Pelias containers. Connects pelias/interpolation#245 Connects pelias/pelias#800
@cymen your version works fine even in alpine-13 |
@nelsonlarocca I missed this but the process I have using this is consuming 2 GB of memory. So I would guess you need 2 GB to run it. Is the build failing though? Not sure how much is required to build it. Maybe try 4 GB if you can? |
node -v == v13.1.0
npm -v == 6.12.1
I can successfully use address parser..
error log ==
/home/ec2-user/.cache/node-gyp/13.1.0/include/node/v8.h:3427:37: note: candidate expects 3 arguments, 2 provided make: *** [Release/obj.target/expand/src/expand.o] Error 1 make: Leaving directory
/efs/pelias-code/interpolation/node_modules/node-postal/build'gyp ERR! build error
gyp ERR! stack Error:
make
failed with exit code: 2gyp ERR! stack at ChildProcess.onExit (/home/ec2-user/.nvm/versions/node/v13.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack at ChildProcess.emit (events.js:210:5)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 4.14.146-120.181.amzn2.x86_64
gyp ERR! command "/home/ec2-user/.nvm/versions/node/v13.1.0/bin/node" "/home/ec2-user/.nvm/versions/node/v13.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /efs/pelias-code/interpolation/node_modules/node-postal
gyp ERR! node -v v13.1.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok
The text was updated successfully, but these errors were encountered: