Skip to content

Commit ae0e7a1

Browse files
andycallandycall
committed
Merge remote-tracking branch 'origin/main' into beta/0.14.2
2 parents 9ffe8ee + aafcda7 commit ae0e7a1

File tree

8 files changed

+66
-8
lines changed

8 files changed

+66
-8
lines changed

‎bridge/core/html/parser/html_parser.cc

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
#include <utility>
77

8+
#include "core/dom/comment.h"
89
#include "core/dom/document.h"
910
#include "core/dom/element.h"
1011
#include "core/dom/text.h"
@@ -92,6 +93,23 @@ void HTMLParser::traverseHTML(Node* root_node, GumboNode* node) {
9293
} else if (child->type == GUMBO_NODE_TEXT) {
9394
auto* text = context->document()->createTextNode(AtomicString(ctx, child->v.text.text), ASSERT_NO_EXCEPTION());
9495
root_container->AppendChild(text);
96+
} else if (child->type == GUMBO_NODE_WHITESPACE) {
97+
bool isBlankSpace = true;
98+
int nLen = strlen(child->v.text.text);
99+
for (int j = 0; j < nLen; ++j) {
100+
isBlankSpace = child->v.text.text[j] == ' ';
101+
if (!isBlankSpace) {
102+
break;
103+
}
104+
}
105+
106+
if (isBlankSpace) {
107+
if (nLen > 0) {
108+
auto* textNode =
109+
context->document()->createTextNode(AtomicString(ctx, child->v.text.text), ASSERT_NO_EXCEPTION());
110+
root_container->appendChild(textNode, ASSERT_NO_EXCEPTION());
111+
}
112+
}
95113
}
96114
}
97115
}

‎integration_tests/scripts/html_loader.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,10 @@ const loader = function(source) {
5151
}
5252
})
5353

54-
const htmlString = root.toString().replace(/['\n]/g, function(c){
55-
return {'\n': '','\'': '\\'}[c];
56-
});
57-
5854
return `
5955
describe('HTMLSpec/${testRelativePath}', () => {
6056
// Use html_parse to parser html in html file.
61-
const html_parse = () => __webf_parse_html__(\`${htmlString}\`);
57+
const html_parse = () => __webf_parse_html__(\`${root.toString()}\`);
6258
var index = 0;
6359
const snapshotAction = async () => { await snapshot(null, '${snapshotFilepath}', ${scripts.length === 0 ? 'null' : 'index.toString()'}); index++; };
6460
${isFit ? 'fit' : isXit ? 'xit' : 'it'}("should work", async (done) => {\

‎integration_tests/snapshots/css/css-empty/empty.html.6ddf1fc01.png

7.62 KB
Loading

‎integration_tests/specs/css/css-box/margin_collapse-001-manual.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,5 @@
5050
</body>
5151
<script>
5252
await snapshotAction();
53-
await sleep(0.1);
5453
</script>
5554
</html>

‎integration_tests/specs/css/css-empty/empty.html

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
<!DOCTYPE html>
2+
<html>
3+
<head>
4+
<style>
5+
6+
.emptyStyle:empty {
7+
background: #ff0000;
8+
height: 50px;
9+
width: 300px;
10+
}
11+
</style>
12+
</head>
13+
14+
<body class="emptyStyle">
15+
<p>p</p>
16+
<p class="emptyStyle"></p>
17+
<p>p1</p>
18+
<p class="emptyStyle"> </p>
19+
<p>h1</p>
20+
<h1 class="emptyStyle"> </h1>
21+
<p>h2</p>
22+
<h2 class="emptyStyle"></h2>
23+
<p>h3</p>
24+
<p>h4</p>
25+
<div class="emptyStyle" id="debug"></div>
26+
<div class="empty" id="debug1">xx</div>
27+
<div class="emptyStyle" id="debug"> </div>
28+
<div class="empty" id="debug1">xx11</div>
29+
<div class="emptyStyle" id="debug"><!-- xx --></div>
30+
<div class="empty" id="debug1">xx22</div>
31+
<p class="emptyStyle" id="debug"></p>
32+
<div class="empty" id="debug1">xx33</div>
33+
</body>
34+
</html>

‎webf/lib/src/css/query_selector.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,9 @@ class SelectorEvaluator extends SelectorVisitor {
183183

184184
// http://dev.w3.org/csswg/selectors-4/#the-empty-pseudo
185185
case 'empty':
186-
return _element!.childNodes.every((n) => !(n is Element || n is TextNode && n.data.isNotEmpty));
186+
return _element!.childNodes.every((n) =>
187+
!(n is Element || (n is TextNode && n.data.isNotEmpty))
188+
);
187189

188190
// http://dev.w3.org/csswg/selectors-4/#the-blank-pseudo
189191
case 'blank':

‎webf/lib/src/rendering/paragraph.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,9 @@ class WebFRenderParagraph extends RenderBox
241241

242242
/// Compute distance to baseline of last text line
243243
double computeDistanceToLastLineBaseline() {
244+
if (_lineOffset.isEmpty) {
245+
return 0.0;
246+
}
244247
double lastLineOffset = _lineOffset[_lineOffset.length - 1];
245248
ui.LineMetrics lastLineMetrics = _lineMetrics[_lineMetrics.length - 1];
246249

‎webf/lib/src/rendering/text.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,13 @@ class RenderTextBox extends RenderBox with RenderObjectWithChildMixin<RenderBox>
315315

316316
// ' a b c' => 'a b c'
317317
static String _trimLeftWhitespace(String string) {
318-
return string.replaceAllMapped(_trimLeftWhitespaceReg, (Match m) => '${m[1]}');
318+
String result = string.replaceAllMapped(_trimLeftWhitespaceReg, (Match m) =>
319+
'${m[1]}'
320+
);
321+
if (result.startsWith(' ')) {
322+
return '';
323+
}
324+
return result;
319325
}
320326

321327
// 'a b c ' => 'a b c'

0 commit comments

Comments
 (0)