[change] Instead of reloading supervisor after changes, restart only the affected process

[pandafy]

The reload supervisor handler affects all the supervisor processes that are running on the system.

ansible-wireguard-openwisp/handlers/main.yml

Lines 3 to 4 in b34b5f4

	- name: reload supervisor
	command: supervisorctl reload

This could cause unwanted downtime for other supervisor processes running on the system. We shall update this handler to only restart the affected supervisor process. The supervisor process name can be deduced as follows:

openwisp-flask-vpn-updater-{{ openwisp2_wireguard_vpn_uuid }}

We have done similar change in ansible-openwisp2 in this PR openwisp/ansible-openwisp2#392

[pandafy]

We can keep this simple by updating the reload supervisor handler like this

- name: Restart wireguard updater flask app
  command: "supervisorctl restart openwisp-flask-vpn-updater-{{ openwisp2_wireguard_vpn_uuid }}"

This is untested code, we would need proper manual testing for this.

[shwetd19]

this specific suggested change to restart only the specific supervisor process instead of reloading all processes is a good improvement. I ahd some of the recommendations here:

1. Update handler name to be more specific:

- name: restart wireguard vpn updater
  command: "supervisorctl restart openwisp-flask-vpn-updater-{{ openwisp2_wireguard_vpn_uuid }}"

2. Add error handling in case the process doesn't exist:

- name: restart wireguard vpn updater
  command: "supervisorctl restart openwisp-flask-vpn-updater-{{ openwisp2_wireguard_vpn_uuid }}"
  register: supervisor_restart
  failed_when: >
    supervisor_restart.rc != 0 and
    'ERROR (no such process)' not in supervisor_restart.stderr

3. Update the tasks referencing the old handler name to use the new one

These changes would need testing to verify proper behavior, especially around process restart timing and error scenarios.

[DarshiniKurasa]

Hey! I’m in.
I’ll tweak the handler so it restarts just the supervisor process like you mentioned. I’ll update the handler’s name and references, and throw in some basic error handling too.
I’ll get a PR up soon.