[connection] Fix update_config task incorrectly detecting itself as duplicate #1204

The _is_update_in_progress function was incorrectly returning True when
the only active task was the current task itself, causing the worker to
skip execution thinking another worker was handling it.

Fixed by:
- Adding current_task_id parameter to _is_update_in_progress()
- Using bind=True on update_config task to access self.request.id
- Excluding the current task when checking for active duplicates
- Added unit tests to verify the fix

Fixes #1204

Author: SAMurai-16

openwisp_controller/connection/tasks.py

@@ -24,9 +24,11 @@ def _is_update_in_progress(device_id, current_task_id=None):
     for task_list in active.values():
         for task in task_list:
             # skip the current task itself
-            if current_task_id and task["id"] == current_task_id:
+            if current_task_id and task.get("id") == current_task_id:
                 continue
-            if task["name"] == _TASK_NAME and str(device_id) in task["args"]:
+            if task.get("name") == _TASK_NAME and str(device_id) in task.get(
+                "args", ""
+            ):
                 return True
     return False
 

openwisp_controller/connection/tests/test_tasks.py

@@ -116,9 +116,7 @@ def test_is_update_in_progress_without_current_task_id(self, mock_app):
         # BUG: Without passing current_task_id, the function returns True
         # even though the only active task IS the current task
         result = _is_update_in_progress(device_id)
-        self.assertTrue(
-            result,
-        )
+        self.assertTrue(result)
 
     @mock.patch("openwisp_controller.connection.tasks.current_app")
     def test_is_update_in_progress_with_current_task_id_excluded(self, mock_app):
@@ -132,9 +130,7 @@ def test_is_update_in_progress_with_current_task_id_excluded(self, mock_app):
 
         # FIX: With current_task_id provided, the function correctly returns False
         result = _is_update_in_progress(device_id, current_task_id=current_task_id)
-        self.assertFalse(
-            result,
-        )
+        self.assertFalse(result)
 
     @mock.patch("openwisp_controller.connection.tasks.current_app")
     def test_is_update_in_progress_detects_another_task(self, mock_app):
@@ -161,9 +157,7 @@ def test_is_update_in_progress_detects_another_task(self, mock_app):
 
         # Should return True because another task IS running
         result = _is_update_in_progress(device_id, current_task_id=current_task_id)
-        self.assertTrue(
-            result,
-        )
+        self.assertTrue(result)
 
     @mock.patch("openwisp_controller.connection.tasks.current_app")
     def test_is_update_in_progress_no_active_tasks(self, mock_app):
@@ -185,9 +179,7 @@ def test_is_update_in_progress_different_device(self, mock_app):
         )
 
         result = _is_update_in_progress(device_id, current_task_id="task-123")
-        self.assertFalse(
-            result,
-        )
+        self.assertFalse(result)
 
 
 class TestTransactionTasks(