[bug] Celery worker skips execution of update_config task due to incorrect self-detection

[pandafy]

Describe the bug
When the celery worker executes openwisp_controller.connection.tasks.update_config, it incorrectly detects that another worker is executing the task, when in reality it is the same worker running it. As a result, the worker returns early, skipping the actual execution even though it is the correct one to run the task.

Steps To Reproduce
Steps to reproduce the behavior:

1. Change the configuration of device (e.g. change name or configuration)
2. Observe the log/output during the task's execution from the celery worker.
3. Notice that the task exits/returns early, incorrectly assuming another worker is executing it, despite being run by the current worker itself.

Expected behavior
The celery worker should correctly detect if another worker is running the task, and should proceed with execution when it is indeed the task's actual worker.

openwisp-controller/openwisp_controller/connection/tasks.py

Lines 19 to 28 in cbdb3c6

	def _is_update_in_progress(device_id):
	active = current_app.control.inspect().active()
	if not active:
	return False
	# check if there's any other running task before adding it
	for task_list in active.values():
	for task in task_list:
	if task["name"] == _TASK_NAME and str(device_id) in task["args"]:
	return True
	return False

[SAMurai-16]

Hi @pandafy i would like to work on this issue

[pandafy]

Sure, go ahead! We will first need a unit test to reliably replicate this issue in the test suite.

…

On Mon, 26 Jan, 2026, 20:33 Samyak Choudhary, ***@***.***> wrote: *SAMurai-16* left a comment (openwisp/openwisp-controller#1204) <#1204 (comment)> Hi @pandafy <https://github.com/pandafy> i would like to work on this issue — Reply to this email directly, view it on GitHub <#1204 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHU3RYMTQ6ISSEZ5LB4F4Z34IYUEJAVCNFSM6AAAAACS5HTEUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBQGA2DQOJUGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>