Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Sessions are fetched also when they shouldn't #274

Open
nemesifier opened this issue Jun 16, 2021 · 3 comments
Open

[bug] Sessions are fetched also when they shouldn't #274

nemesifier opened this issue Jun 16, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@nemesifier
Copy link
Member

I have observed the application trying to fetch sessions also when it shouldn't and in some cases the requests can even fail because there's no valid token in memory anymore.

I guess this is happening because the periodic fetching is not cleared properly on component unmount, either the code which does the clearing of the interval is wrong or there's some other part of the application which prevents the unmounting from being performed correctly.

Here's how I am able to replicate this:

  • sign up with mobile phone number verification
  • in the verification page, check the network tab in the developer console

Screenshot from 2021-06-16 13-35-14

@nemesifier nemesifier added the bug Something isn't working label Jun 16, 2021
@codesankalp
Copy link
Member

I tried to replicate this as mentioned in the issue description but the verification page is not calling the session API @nemesisdesign

@nemesifier
Copy link
Member Author

I tried to replicate this as mentioned in the issue description but the verification page is not calling the session API @nemesisdesign

I will add more info if I can replicate again, otherwise I will close it, thanks!

@nemesifier
Copy link
Member Author

nemesifier commented Aug 26, 2021

This happened to me again during testing but I am not able to reproduce it consistently yet.
It's just a matter of time before i'll understand how to replicate it so we can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants