Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Allowed showing failure messages coming from captive portal … #833

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

praptisharma28
Copy link
Member

@praptisharma28 praptisharma28 commented Nov 6, 2024

#604

Closes #604

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #604 .

Description of Changes

  • Added captive-portal-handler.js to handle authentication failure detection and error messaging.
  • When a captive portal authentication fails, it redirects back to the login page.

Also:

  • By changing to:

import LoginComponent from "../login";

  • We're getting the default export (the connected component) and there's no ambiguity about which version we're using as I was getting ESLint error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change] Allow showing failure messages coming from captive portal
1 participant