blob: deprecate int8 and int16 #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alphix
reviewed
Nov 13, 2025
blob.h
Outdated
Comment on lines
125
to
128
| static inline uint8_t | ||
| blob_get_u8(const struct blob_attr *attr) | ||
| blob_get_bool(const struct blob_attr *attr) | ||
| { | ||
| return *((uint8_t *) attr->data); |
Contributor
There was a problem hiding this comment.
Shouldn't this be:
static inline bool
blob_get_bool(const struct blob_attr *attr)
{
return *((uint8_t *)attr->data) ? true : false;
}And similar for _put_bool() and _add_bool()
Member
Author
There was a problem hiding this comment.
I'm not so sure - the normal coercion to boolean happens elsewhere based on the uint 8 data, not on t/f, for existing implementations. But I've not looked this change as a whole.
In order to deprecate u8 functions we need to add proper boolean functions first. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Deprecate u8 and u16 to avoid a lot of compatibility mess and JSON conversion issues. Due to padding, u8, u16 and u32 attributes have the same effective size anyway, so there isn't really a good reason to use them for integer values. Signed-off-by: Álvaro Fernández Rojas <[email protected]>
Noltari
force-pushed
the
deprecate-int8-int16
branch
from
71b36c2 to
d3b1b66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @nbd168 @systemcrash @Alphix