mtpoe-ctrl: add new package #24638
mtpoe-ctrl: add new package #24638
Conversation
prudy
force-pushed
the
mtpoe-ctrl-rb5009
branch
2 times, most recently
from
5da28e0 to
923f7d6
Compare
| PKG_RELEASE:=18 | ||
|
|
||
| PKG_SOURCE_PROTO:=git | ||
| PKG_SOURCE_URL:=https://github.com/prudy/mtpoe_ctrl.git |
There was a problem hiding this comment.
I wonder, why did you forked the original repository and there isnt anything new.
There was a problem hiding this comment.
There are changes to adapt for the v4 of the protocol. They are awaiting with th PR to original author repo. Till then it points to my fork.
| PKG_SOURCE_VERSION:=9c42b74274cca10810363dbbb6d161bfb9cedb7e | ||
| PKG_MIRROR_HASH:=1ac2902161ba4bb1e8af397aa48821ccea95740199b1c155f98161c7ff3a93df | ||
| PKG_VERSION:=1.15 | ||
| PKG_RELEASE:=18 |
There was a problem hiding this comment.
That's the original version as forked. Then the PKG_VERSION was bumped up to 1.15.
| PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) | ||
|
|
||
| PKG_MAINTAINER:=Sergey Sergeev <[email protected]> | ||
| PKG_LICENSE:=GPL-2.0 |
There was a problem hiding this comment.
SPDX license identifier is deprecated. You need to check the latest one.
There was a problem hiding this comment.
Well, the original repo states:
Licence is GNU GPL V3
There was a problem hiding this comment.
Yes, but not in here https://github.com/adron-s/mtpoe_ctrl/blob/master/openwrt/package/utils/mtpoe_ctrl/Makefile
Anyway, for compatibility, shall I request for a GPL-2.0-or-later solely dual licensing for use by openwrt/packages?
There was a problem hiding this comment.
I think that the license information in the source code repository is the only valid info, the one in OpenWrt package description is more for automated SBOM generation than anything else.
It cannot be dual licensed if the repo is GPL v3
There was a problem hiding this comment.
Can you then take mtpoe code as part of packages at all? I doubt it.
| endef | ||
|
|
||
| define Package/mtpoe-ctrl/description | ||
| Management utility for Mikrotiks PoE V2/V3/V4 |
There was a problem hiding this comment.
This description is the same as TITLE. :-( Not very informative.
There was a problem hiding this comment.
I did not touch it, although it makes sense to change it.
utils/mtpoe-ctrl/Makefile
Outdated
| PKG_SOURCE_VERSION:=9c42b74274cca10810363dbbb6d161bfb9cedb7e | ||
| PKG_MIRROR_HASH:=1ac2902161ba4bb1e8af397aa48821ccea95740199b1c155f98161c7ff3a93df |
There was a problem hiding this comment.
This ordering is not correct, you should check how it is done in other Makefiles.
There was a problem hiding this comment.
It also comes from the original repo approach. Will see.
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) |
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) | ||
|
|
||
| PKG_MAINTAINER:=Sergey Sergeev <[email protected]> |
There was a problem hiding this comment.
I did not notify him beside raising a PR to original repo. It's not a problem to put me there, and update when original author takes the PR. I keep that on purpose, not to take credit for someone's work.
There was a problem hiding this comment.
Maintainership doesnt mean any credits other than you are the person that gets pinged on updates or issues.
prudy
force-pushed
the
mtpoe-ctrl-rb5009
branch
from
923f7d6 to
d4a5b2d
Compare
Provides the tool for controlling PoE on MikroTik routers. It requires the PoE controller exposed to the user-space. Signed-off-by: Przemek Rudy <[email protected]>
Add explicit handling for RB5009UG. Signed-off-by: Przemek Rudy <[email protected]>
BKPepe
force-pushed
the
mtpoe-ctrl-rb5009
branch
from
d4a5b2d to
7c2b528
Compare
4 participants
Maintainer: @prudy (original maintainer will be updated when accepts the PR)
Compile tested: mvebu, mikrotik_rb5009, OpenWrt r26983-1ca6a7583b
Run tested: mvebu, mikrotik_rb5009, OpenWrt r26983-1ca6a7583b, tests done
Description:
Tool for controlling the PoE on Mikrotik devices. It has been ported to work on rb5009 router model.
This requires spi access to the controller, which is posted as an OpenWrt pull-request.