Skip to content

Conversation

@dangowrt
Copy link
Member

Maintainer: me
Compile tested: aarch64/cortex-a53
Run tested: -

Description:
This reverts commit 3dbefd2. openwrt/openwrt@72accd078f fixes the actual issue of 'flex' not working unless the M4 environment variable is set, which isn't done in case of building with CMake or Meson.

I'm going to follow up and update PostgreSQL to 16.4 for the upcoming openwrt-24.10 branch, and then to PostgreSQL 17.0 in the development branch.

@dangowrt dangowrt requested a review from hnyman September 27, 2024 00:33
@hnyman
Copy link
Contributor

hnyman commented Sep 27, 2024

Well, I have not specific knowledge, but CI seems to dislike your changes.

 [234/1612] Generating src/fe_utils/psqlscan with a custom command
FAILED: src/fe_utils/psqlscan.c 
/builder/staging_dir/host/bin/python3 ../src/tools/pgflex --builddir . --srcdir .. --privatedir src/fe_utils/psqlscan.c.p --flex /builder/staging_dir/host/bin/flex --perl /builder/staging_dir/host/bin/perl -i ../src/fe_utils/psqlscan.l -o src/fe_utils/psqlscan.c --no-backup --fix-warnings -- -Cfe -p -p
flex: fatal internal error, exec of /builder/shared-workdir/build/staging_dir/host/bin/m4 failed
[235/1612] Compiling C object src/interfaces/libpq/libpq.so.5.16.p/libpq-events.c.o
[236/1612] Compiling C object src/interfaces/libpq/libpq.so.5.16.p/pqexpbuffer.c.o
[237/1612] Compiling C object src/interfaces/libpq/libpq.so.5.16.p/fe-connect.c.o
ninja: build stopped: subcommand failed.
make[2]: *** [Makefile:264: /builder/build_dir/target-mips_24kc_musl/postgresql-16.3/.built] Error 1
make[2]: Leaving directory '/feed/libs/postgresql'
time: package/feeds/packages_ci/postgresql/compile#41.27#17.80#32.34
    ERROR: package/feeds/packages_ci/postgresql failed to build.

@dangowrt
Copy link
Member Author

@hnyman This looks like openwrt/openwrt@72accd078f has not yet been applied to the container used for CI. How can we know which commit level the SDK used in the container is on?

@hnyman
Copy link
Contributor

hnyman commented Sep 27, 2024

You should rebase the PR branch once the SDK has surely been rebuilt in images phase1 buildbot, so that the new CI round gets triggered.

@dangowrt dangowrt force-pushed the reapply-postgresql-16.3 branch from c56eae6 to 4c2fe66 Compare September 28, 2024 21:15
@dangowrt dangowrt force-pushed the reapply-postgresql-16.3 branch 2 times, most recently from 529f133 to a1fdcf9 Compare October 11, 2024 00:00
@dangowrt dangowrt force-pushed the reapply-postgresql-16.3 branch from a1fdcf9 to bcbf17d Compare October 26, 2024 18:22
This reverts commit 3dbefd2.
openwrt/openwrt@72accd078f fixes the actual issue of 'flex' not working
unless the M4 environment variable is set, which isn't done in case of
building with CMake or Meson.

Signed-off-by: Daniel Golle <[email protected]>
@dangowrt dangowrt force-pushed the reapply-postgresql-16.3 branch from bcbf17d to 268206a Compare November 9, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants