net-snmp: refactor Makefile for optional variant with openssl and logging #25444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckorber
force-pushed
the
pr/net-snmp
branch
2 times, most recently
from
063324f to
91c1e21
Compare
ckorber
force-pushed
the
pr/net-snmp
branch
2 times, most recently
from
8bda243 to
9be48e9
Compare
Author
|
@stintel : I updated the Makefile in a way that it is possible to compile snmp with or without openssl. |
ckorber
force-pushed
the
pr/net-snmp
branch
4 times, most recently
from
d921a24 to
da99ac5
Compare
Author
|
@stintel : Did you find time to look into the changes? |
Member
Sorry, a bit busy with life. Might be a while. Without reviewing the code the following question comes to mind: can the user still do |
Author
|
I understand that and I didn't have in mind to pressure you. |
Author
|
Hello @stintel , |
stintel
requested changes
Feb 14, 2025
Member
stintel
left a comment
stintel
left a comment
There was a problem hiding this comment.
Also please add example sections in net/net-snmp/files/snmpd.conf for both SNMPv3 and logging.
Member
|
Build test on qoriq shows a bunch of conflicts. I ran |
Author
|
Thank you for your review! EDIT: Also added v3 and logging options to snmpd.conf. |
ckorber
force-pushed
the
pr/net-snmp
branch
5 times, most recently
from
6561ab5 to
95be69b
Compare
Author
|
@stintel : Are these changes what you had in mind? |
Member
|
The config examples should be in the commit that adds that specific config option. Also, I noticed you added meta packages net-snmp-ssl and net-snmp-nossl, these should go in a separate commit also. And finally, I'm now getting these errors during make oldconfig: |
ckorber
force-pushed
the
pr/net-snmp
branch
4 times, most recently
from
d9c06bb to
b327507
Compare
added 3 commits
February 25, 2025 08:38
Following commits will introduce a new variant ssl that provides ssl encryption possibility needed by SNMP V3. So this commit tags the basic variant nossl and encapsulates needed packages in the same logic. Signed-off-by: Christian Korber <[email protected]>
This commit introduces the new ssl variant of net-snmp. It also integrates a differentiation between the now two variants and compiles them conditionally. Signed-off-by: Christian Korber <[email protected]>
In this commit, the init script is adapted to enable SNMP V3 and a default config is provided. Signed-off-by: Christian Korber <[email protected]>
Author
|
@stintel : I resolved the error log reason. Again, thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @stintel
Compile tested: x86_64, Openwrt 24.10
Run tested: x86_64, Openwrt 24.10
Description:
Openssl is needed to implement encryption and authentification for SNMPv3.
As discussed in PR #25178 , I added a variant for net-snmp that compiles libnetsnmp
with libopenssl (for SNMPv3). The default compilation is with the former variant.
The features for SNMPv3 are added to snmpd.init file and the possibility
to log messages to syslog or a log file..