Skip to content

Conversation

@vidplace7
Copy link
Contributor

@vidplace7 vidplace7 commented Dec 12, 2024

Maintainer: @commodo @BKPepe
Compile tested: OpenWRT One 24.10 branch

Description:
Add hostbuild directives for python-requests and it's dependencies. Required for PlatformIO 24.10 backport.

Backport to 24.10

Cherry-picked PRs:

Related PRs:

@BKPepe
Copy link
Member

BKPepe commented Dec 12, 2024

I will gladly accept this, when we first have it all working in the master branch.

@vidplace7
Copy link
Contributor Author

I will gladly accept this, when we first have it all working in the master branch.

Everything related to requests has been merged into master, is there something else that needs to be done?
Or would you like for me to wait for all of my PRs to get merged into master first?

@BKPepe
Copy link
Member

BKPepe commented Dec 14, 2024

No, no. You are adding packages to the master branch to have a working PlatformIO, which has not been added so far. Once it is verified to be working in the master branch to see the why the host packages were added, then it could be backported. Nonetheless, for now, backporting hostbuilds for OpenWrt 24.10 does not make any sense.

@vidplace7 vidplace7 force-pushed the backport24-python-requests_host branch from 6df94eb to c5d5f28 Compare December 14, 2024 15:43
@ynezz
Copy link
Member

ynezz commented Dec 16, 2024

No, no. You are adding packages to the master branch to have a working PlatformIO, which has not been added so far. Once it is verified to be working in the master branch to see the why the host packages were added, then it could be backported. Nonetheless, for now, backporting hostbuilds for OpenWrt 24.10 does not make any sense.

FYI you can see it already here https://github.com/openwrt-meshtastic/openwrt-meshtastic/actions/runs/12342391075, the packages are available in https://github.com/openwrt-meshtastic/repo/tree/gh-pages/main

@vidplace7
Copy link
Contributor Author

No, no. You are adding packages to the master branch to have a working PlatformIO, which has not been added so far. Once it is verified to be working in the master branch to see the why the host packages were added, then it could be backported. Nonetheless, for now, backporting hostbuilds for OpenWrt 24.10 does not make any sense.

FYI you can see it already here https://github.com/openwrt-meshtastic/openwrt-meshtastic/actions/runs/12342391075, the packages are available in https://github.com/openwrt-meshtastic/repo/tree/gh-pages/main

Hey @ynezz :) I'm glad you found my "repo".
The ultimate goal is outlined at https://github.com/openwrt-meshtastic/openwrt-meshtastic/blob/main/upstreaming.md

As you saw, I am doing my best to test each package thoroughly and for as many archs as I can. I really appreciate all of the OpenWRT team's critical feedback so I can make these contributions meaningful.

@mhei mhei added the OpenWrt 24.10 Issue/PR on branch 24.10 label Dec 23, 2024
@vidplace7 vidplace7 force-pushed the backport24-python-requests_host branch from c5d5f28 to d129ccd Compare June 10, 2025 17:19
@vidplace7
Copy link
Contributor Author

I will gladly accept this, when we first have it all working in the master branch.

@BKPepe can this be revisited? Has been working happily in master for months 😃

@BKPepe
Copy link
Member

BKPepe commented Jun 11, 2025

Sure, would be nice if your all commits has description, that it was cherry-picked from the master branch.
You can do it by git cherry-pick -x hash

@vidplace7 vidplace7 force-pushed the backport24-python-requests_host branch from d129ccd to 70a131d Compare June 11, 2025 10:32
Signed-off-by: Austin Lane <[email protected]>

(cherry picked from commit 7db7fd2)
Signed-off-by: Austin Lane <[email protected]>

(cherry picked from commit 6bb68d4)
Signed-off-by: Austin Lane <[email protected]>

(cherry picked from commit 955976c)
Signed-off-by: Austin Lane <[email protected]>

(cherry picked from commit d6c644c)
Signed-off-by: Austin Lane <[email protected]>

(cherry picked from commit edf093f)
@vidplace7 vidplace7 force-pushed the backport24-python-requests_host branch from 70a131d to 52f8cbb Compare June 11, 2025 10:35
@vidplace7
Copy link
Contributor Author

Sure, would be nice if your all commits has description, that it was cherry-picked from the master branch. You can do it by git cherry-pick -x hash

Commits have been amended as requested 🍻

@BKPepe BKPepe merged commit 32083d1 into openwrt:openwrt-24.10 Jun 11, 2025
13 of 14 checks passed
@vidplace7 vidplace7 deleted the backport24-python-requests_host branch September 3, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OpenWrt 24.10 Issue/PR on branch 24.10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants