Skip to content

Conversation

@systemcrash
Copy link
Contributor

This satisfies other packages which might depend on either chrony variant.

E.g. luci interface where either -nts or non variants are acceptable.

📦 Package Details

Maintainer: @mlichvar

@mlichvar
Copy link
Contributor

Will the non-nts variant be installed when the user or another package requires "chrony", or will it be selected randomly between chrony and chrony-nts? I think chrony-nts should be installed only when requested to avoid pulling its large dependencies.

Maybe it would be safer to call the new provide "chrony-any" and use that in the luci app?

@systemcrash
Copy link
Contributor Author

Will the non-nts variant be installed when the user or another package requires "chrony", or will it be selected randomly between chrony and chrony-nts? I think chrony-nts should be installed only when requested to avoid pulling its large dependencies.

Maybe it would be safer to call the new provide "chrony-any" and use that in the luci app?

Not unreasonable. There's the flag DEFAULT_VARIANT:=1 which is now set for the non-NTS variant.

@mlichvar
Copy link
Contributor

Ok, looks good to me. Thanks.

@systemcrash
Copy link
Contributor Author

repo maintainer ping

@BKPepe
Copy link
Member

BKPepe commented Nov 6, 2025

I assigned it to myself because it doesn't seem to me that it would be completely right and there's no need to keep reminding about it. I have it in the queue. :-) A little patience, please. I'd say this isn't as urgent as some things, for example fixing Python packages.

@systemcrash
Copy link
Contributor Author

Solution: ban python from openwrt :D

@systemcrash
Copy link
Contributor Author

Gonna ping on this again because it is actually needed...

@1715173329
Copy link
Member

@BKPepe any idea?

@1715173329
Copy link
Member

I plan to merge this once CI passed.

An NTP client and server designed to perform well in a wide range
of conditions. It can synchronize the system clock with NTP servers,
reference clocks, and manual input using wristwatch and keyboard.
This package does NOT include NTS support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This package does NOT include NTS support and secure hash functions.

@systemcrash
Copy link
Contributor Author

Fixed.

This satisfies other packages which might depend on either chrony variant.

Should another package dependency request 'chrony', the default will be non-NTS
chrony via DEFAULT_VARIANT:=1 (mlichvar comment:  to avoid pulling its large
dependencies).

Signed-off-by: Paul Donald <[email protected]>
Update URL to current distro source
drop provides:=nts since it is unused anywhere

Signed-off-by: Paul Donald <[email protected]>
@1715173329
Copy link
Member

I guess this should be okay to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants