-
Notifications
You must be signed in to change notification settings - Fork 3.8k
chrony: add provides logic to Makefile #27723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Will the non-nts variant be installed when the user or another package requires "chrony", or will it be selected randomly between chrony and chrony-nts? I think chrony-nts should be installed only when requested to avoid pulling its large dependencies. Maybe it would be safer to call the new provide "chrony-any" and use that in the luci app? |
f5edf29 to
38cf9bc
Compare
Not unreasonable. There's the flag |
|
Ok, looks good to me. Thanks. |
38cf9bc to
294a625
Compare
|
repo maintainer ping |
|
I assigned it to myself because it doesn't seem to me that it would be completely right and there's no need to keep reminding about it. I have it in the queue. :-) A little patience, please. I'd say this isn't as urgent as some things, for example fixing Python packages. |
|
Solution: ban python from openwrt :D |
|
Gonna ping on this again because it is actually needed... |
|
@BKPepe any idea? |
294a625 to
e220fb7
Compare
|
I plan to merge this once CI passed. |
| An NTP client and server designed to perform well in a wide range | ||
| of conditions. It can synchronize the system clock with NTP servers, | ||
| reference clocks, and manual input using wristwatch and keyboard. | ||
| This package does NOT include NTS support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This package does NOT include NTS support and secure hash functions. |
e220fb7 to
d809b53
Compare
d809b53 to
f7d4c05
Compare
|
Fixed. |
This satisfies other packages which might depend on either chrony variant. Should another package dependency request 'chrony', the default will be non-NTS chrony via DEFAULT_VARIANT:=1 (mlichvar comment: to avoid pulling its large dependencies). Signed-off-by: Paul Donald <[email protected]>
Update URL to current distro source drop provides:=nts since it is unused anywhere Signed-off-by: Paul Donald <[email protected]>
f7d4c05 to
f895a79
Compare
|
I guess this should be okay to go. |
This satisfies other packages which might depend on either chrony variant.
E.g. luci interface where either -nts or non variants are acceptable.
📦 Package Details
Maintainer: @mlichvar