ddns-scripts: Use parameter-based authentication for he.net #27921
Conversation
|
problem is that we need https and certificate support for this? |
|
Well, I don't see this to be a problem, to be honest. Theoretically we could drop the https in favor of http, but at least for 18 other services,
Is anyone really willing to send credentials (either via HTTP Basic Auth and/or via URL) over non-encrypted HTTP channels these days anyway? |
|
no one should you are right... just not sure if ddns depends on ssl and ca-certificates... i assume yes? |
|
From my point of view this is a more fundamental discussion that should be addressed - but not in this pull request. I can't find an explicit dependency in the Makefile, but this is also true for any of the other 18 services that are using So, another PR might be needed to add SSL support explicitly. |
feckert
left a comment
feckert
left a comment
There was a problem hiding this comment.
Please bump the PKG_RELEASE in the Makefile
This bumps the PKG_RELEASE after the last commit, as requested by @feckert [1]. [1]: openwrt#27921 (review) Signed-off-by: Karol Babioch <[email protected]>
|
Done with 0648669 |
|
Please squash this two commits so we have only one in this PR |
kbabioch
force-pushed
the
fix-he-net-ddns
branch
from
0648669 to
dd33436
Compare
|
Personally I much prefer atomic commits for independent tasks, but here you go: dd33436 |
|
Thanks merged!! Regarding the https topic, see #27940 |
According to [1] Basic Auth seems to be broken since a while for he.net. The documentation [2] is outdated, and still mentions Basic Auth, but switching to parameter-based authentication seems to fix the issue. It also bumps PKG_RELEASE in order to ensure a new version is packaged. [1]: openwrt#27593 [2]: https://dns.he.net/docs.html Signed-off-by: Karol Babioch <[email protected]>
feckert
force-pushed
the
fix-he-net-ddns
branch
from
dd33436 to
b912bd1
Compare
3 participants
According to 1 Basic Auth seems to be broken since a while for he.net. The documentation 2 is outdated, and still mentions Basic Auth, but switching to parameter-based authentication seems to fix the issue.
📦 Package Details
Maintainer: @feckert (?)
Description:
ddns-scripts: Use parameter-based authentication for he.net
According to 1 Basic Auth seems to be broken since a while for he.net.
The documentation 2 is outdated, and still mentions Basic Auth, but
switching to parameter-based authentication seems to fix the issue.
Signed-off-by: Karol Babioch [email protected]
✅ Formalities