Skip to content

Conversation

@betonmischer86
Copy link

📦 Package Details

Maintainer: @
(You can find this by checking the history of the package Makefile.)

Description:
Fastfetch is a Neofetch-like tool for fetching system information and displaying it in a visually-appealing way.


🧪 Run Testing Details

  • OpenWrt Version: OpenWrt SNAPSHOT r31813
  • OpenWrt Target/Subtarget: mediatek/filogic
  • OpenWrt Device: Banana Pi BPI-R4 (2x SFP+)

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

Copy link
Member

@GeorgeSapkin GeorgeSapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the other PRs, you need to set yourself as the maintainer and don't need to include the license file.

Comment on lines 44 to 49
$(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/share/bash-completion/completions/* \
$(1)/usr/share/bash-completion/completions/
$(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/share/fish/vendor_completions.d/* \
$(1)/usr/share/fish/vendor_completions.d/
$(INSTALL_DATA) $(PKG_INSTALL_DIR)/usr/share/zsh/site-functions/* \
$(1)/usr/share/zsh/site-functions/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these really needed on a router? Considering neither of those shells are the default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these really needed on a router? Considering neither of those shells are the default.

Since Fastfetch is one of those nice-to-haves that will only be installed on systems with storage space to spare and the completions directories are only 12K each, I decided to include those too. Let me know if you'd like me to drop them anyway.

Fastfetch is a Neofetch-like tool for fetching system information and
displaying it in a visually-appealing way.

Signed-off-by: Valeriy Kosikhin <[email protected]>
@betonmischer86
Copy link
Author

As with the other PRs, you need to set yourself as the maintainer and don't need to include the license file.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants