shine: fix compile bug in l3mdct #27958
Conversation
There was a problem hiding this comment.
This patch needs a header.
There was a problem hiding this comment.
Not only header, but it looks like this needs to be solved in upstream.
- Is this backport?
- Was it submitted to upstream?
🤔
There was a problem hiding this comment.
What for? Upstream looks dead to me: https://github.com/toots/shine
There was a problem hiding this comment.
So when this patch becomes dirty for whatever reason, the next contributor understands where this is coming from without looking through PRs and commits and knows what to do with it.
Alternatively, drop the package, if the upstream is not maintained.
There was a problem hiding this comment.
Drop is also an option. Seems it's pulled only because InstallDev.
GeorgeSapkin
left a comment
GeorgeSapkin
left a comment
There was a problem hiding this comment.
Please use this format in the commit message before the sign-off:
Fixes: https://github.com/openwrt/packages/issues/27957
vooon
force-pushed
the
fix-shine-mdct
branch
from
e32d8d8 to
f2c33cc
Compare
|
It's possible to drop, but then need to fix |
vooon
force-pushed
the
fix-shine-mdct
branch
from
f2c33cc to
18f2efe
Compare
|
GCC 4.8. |
vooon
force-pushed
the
fix-shine-mdct
branch
2 times, most recently
from
2ed619d to
d464fe5
Compare
|
@neheb thanks! Fixed patch author. |
|
No I mean it’s no longer necessary |
vooon
force-pushed
the
fix-shine-mdct
branch
from
d464fe5 to
fa97403
Compare
|
@neheb ah, ok, dropped. |
GeorgeSapkin
left a comment
GeorgeSapkin
left a comment
There was a problem hiding this comment.
This should have a release bump.
- Project has different function declaration in header and source. - Reformat patches for `git am` Fixes: openwrt#27957 Signed-off-by: Vladimir Ermakov <[email protected]>
vooon
force-pushed
the
fix-shine-mdct
branch
from
fa97403 to
7c6acd6
Compare
|
@GeorgeSapkin done. |
5 participants
📦 Package Details
Maintainer: @nicolas-thill
Description:
Fix #27957
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.
Package seems abandoned, but for some reason pulled to build as some kind of dep.