python-urllib3: fix builds with setuptools-scm 9.x #27961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BKPepe
reviewed
Nov 25, 2025
Comment on lines
+1
to
+24
| --- a/pyproject.toml | ||
| +++ b/pyproject.toml | ||
| @@ -1,7 +1,7 @@ | ||
| # This file is protected via CODEOWNERS | ||
|
|
||
| [build-system] | ||
| -requires = ["hatchling>=1.6.0,<2", "hatch-vcs>=0.4.0,<0.6.0", "setuptools-scm>=8,<9"] | ||
| +requires = ["hatchling>=1.6.0,<2", "hatch-vcs>=0.4.0,<0.6.0", "setuptools-scm>=8,<10"] | ||
| build-backend = "hatchling.build" | ||
|
|
||
| [project] |
Member
There was a problem hiding this comment.
Having this patch backported from https://patch-diff.githubusercontent.com/raw/urllib3/urllib3/pull/3682.patch would be much better, so it includes patch header and it helps to know if the patch was submitted to upstream or it was accepted already.
Contributor
Author
There was a problem hiding this comment.
This patch was adapted from 3682.patch but I had to modify it (so not exactly the same) as the minimum hatchling version has been bumped in urllib3 upstream.
I'll re-add the header and make note of this 👍
- Fix builds for python-urllib3 with setuptools-scm - Patch sourced from upstream (un-released/main branch) Signed-off-by: Austin Lane <[email protected]>
vidplace7
force-pushed
the
host-python-urllib3
branch
from
76add9c to
aed5273
Compare
BKPepe
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @BKPepe, @ja-pa, @jefferyto, @Yang-Wei-Ting
Description:
When setuptools-scm was updated to 9.x in #27815 -- urllib3 builds broke!
This has already been fixed upstream by increasing the upper-bounds of setuptools-scm to
<10. Backport this fix in a patch until a new urllib3 tag is released.🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git amThis patch is adapted from upstream pyproject.toml: change setuptools-scm upper limit urllib3/urllib3#3682