watchcat: passing the interface in the ping_reboot #27969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not a maintainer of this package, just a past contributor. |
Author
|
@jtkohl Sorry for that. Do you know who the maintainer is ? The instructions said take a look on the history of the Makefile :) |
Author
Nevermind... I saw afterwards that it was mentioned in the Makefile :) |
Contributor
|
You should also increase the PKG_RELEASE in Makefile. |
Although the watchcat_ping function also checked the iface variable, that variable was never populated. As a result we could not check if there was connectivity via a specific interface. Signed-off-by: Vasileios Anagnostopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @roger- Roger D [email protected]
Description:
Although the watchcat_ping function also checked the iface variable, that variable was never populated. As a result we could not check if there was connectivity via a specific interface and restart the device if there is not.
🧪 Run Testing Details
✅ Formalities