shairport-sync: enable Airplay 2 for shairport-sync-openssl only #27982
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk138
force-pushed
the
master
branch
2 times, most recently
from
9c14d3e to
8b329a9
Compare
https://github.com/mikebrady/shairport-sync/blob/master/ CONFIGURATION%20FLAGS.md#cryptography states that only the OpenSSL cryptography backend is suitable for Airplay 2. Further investigation revealed that the pair_ap module within shairport-sync, which is needed for Airplay 2, does not have an Mbed TLS backend. Accordingly, this commit enables Airplay 2 only for the OpenSSL build. This has the nice side effect that for Airplay 1 the -mini or -mbedtls versions can be used without pulling in 6 MB of ffmepg libs. Signed-off-by: Christian Beier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/mikebrady/shairport-sync/blob/master/CONFIGURATION%20FLAGS.md#cryptography states that only the OpenSSL cryptography backend is suitable for Airplay 2.
Further investigation revealed that the pair_ap module within shairport-sync, which is needed for Airplay 2, does not have an Mbed TLS backend.
Accordingly, this commit enables Airplay 2 only for the OpenSSL build.
This has the nice side effect that for Airplay 1 the -mini or -mbedtls versions can be used without pulling in 6 MB of ffmepg libs.
📦 Package Details
Maintainer: @thess @mikebrady
(You can find this by checking the history of the package
Makefile.)Description:
https://github.com/mikebrady/shairport-sync/blob/master/CONFIGURATION%20FLAGS.md#cryptography states that only the OpenSSL cryptography backend is suitable for Airplay 2.
Further investigation revealed that the pair_ap module within shairport-sync, which is needed for Airplay 2, does not have an Mbed TLS backend.
Accordingly, this commit enables Airplay 2 only for the OpenSSL build.
This has the nice side effect that for Airplay 1 the -mini or -mbedtls versions can be used without pulling in 6 MB of ffmepg libs.
🧪 Run Testing Details
✅ Formalities