cyrus-sasl: depends on libcrypt-compat when building with glibc #27993
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing dependency +USE_GLIBC:libcrypt-compat to express dependency on libcrypto.so.1 when building with GNU glibc. Signed-off-by: Daniel Golle <[email protected]>
dangowrt
force-pushed
the
cyrus-sasl-libcrypt-compat
branch
from
f7f3920 to
de96202
Compare
Contributor
|
Looks good. Recommend merge. Thank you for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @flyn-org
Description:
Add missing dependency
+USE_GLIBC:libcrypt-compatto express dependency onlibcrypto.so.1when building with GNU glibc.Bumping PKG_RELEASE isn't required as the package anyway didn't build against glibc previously and no changes are introduced when building against musl.
✅ Formalities