Skip to content

mcproxy: fix igmpv3 and mld record type #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mcproxy: fix igmpv3 and mld record type #1032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions mcproxy/patches/0008-fix-igmpv3-mld-record-type.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
--- a/mcproxy/src/proxy/igmp_sender.cpp
+++ b/mcproxy/src/proxy/igmp_sender.cpp
@@ -54,10 +54,14 @@ bool igmp_sender::send_record(unsigned int if_index, mc_filter filter_mode, cons
m_sock.leave_group(gaddr, if_index);
return true;
} else if (filter_mode == EXCLUDE_MODE || filter_mode == INCLUDE_MODE) {
- m_sock.join_group(gaddr, if_index);
std::list<addr_storage> src_list;
- for (auto & e : slist) {
- src_list.push_back(e.saddr);
+ if (slist.empty()) {
+ m_sock.join_group(gaddr, if_index);
+ } else {
+ for (auto & e : slist) {
+ m_sock.join_source_group(gaddr, addr_storage(e.saddr), if_index);
+ src_list.push_back(e.saddr);
+ }
}

return m_sock.set_source_filter(if_index, gaddr, filter_mode, src_list);
--- a/mcproxy/src/proxy/mld_sender.cpp
+++ b/mcproxy/src/proxy/mld_sender.cpp
@@ -55,11 +55,15 @@ bool mld_sender::send_record(unsigned int if_index, mc_filter filter_mode, const
if (filter_mode == INCLUDE_MODE && slist.empty() ) {
m_sock.leave_group(gaddr, if_index);
return true;
- } else if (filter_mode == EXCLUDE_MODE || filter_mode == EXCLUDE_MODE) {
- m_sock.join_group(gaddr, if_index);
+ } else if (filter_mode == EXCLUDE_MODE || filter_mode == INCLUDE_MODE) {
std::list<addr_storage> src_list;
- for (auto & e : slist) {
- src_list.push_back(e.saddr);
+ if ( slist.empty() ) {
+ m_sock.join_group(gaddr, if_index);
+ } else {
+ for (auto & e : slist) {
+ m_sock.join_source_group(gaddr, addr_storage(e.saddr), if_index);
+ src_list.push_back(e.saddr);
+ }
}

return m_sock.set_source_filter(if_index, gaddr, filter_mode, src_list);