[xla:cpu] Add DotLibraryRewriter rewrite options for oneDNN and XNNPACK. #28923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_780144549
branch
from
bfef507 to
4ac9d9c
Compare
Also: * Add a template function `SetterForRepeatedEnum` to parse repeated field flags. Make `--xla_gpu_enable_command_buffer` and `--xla_gpu_unsupported_generic_triton_emitter_features` call this generic parser instead. * This fixes existing bugs when parsing `--xla_gpu_enable_command_buffer`: * In add/remove mode, the existing setter only parses the first option and return. This PR makes it parse all options in the list. * The existing setters allow duplicate options. This PR ensures each option appear once. * List the missing `XNN_GRAPH_FUSION_MODE_GREEDY_SLINKY` enum value in the description for `xla_cpu_experimental_xnn_graph_fusion_mode` flag. * Add more keep-sorted keywords to keep XLA:CPU flags sorted in `xla.proto`. * Remove unused headers and dependencies from `debug_options_flags`. PiperOrigin-RevId: 783276995
copybara-service
bot
force-pushed
the
test_780144549
branch
from
4ac9d9c to
6952696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla:cpu] Add DotLibraryRewriter rewrite options for oneDNN and XNNPACK.
Also:
SetterForRepeatedEnumto parse repeated field flags. Make--xla_gpu_enable_command_bufferand--xla_gpu_unsupported_generic_triton_emitter_featurescall this generic parser instead.--xla_gpu_enable_command_buffer:XNN_GRAPH_FUSION_MODE_GREEDY_SLINKYenum value in the description forxla_cpu_experimental_xnn_graph_fusion_modeflag.xla.proto.debug_options_flags.