[xla] Change the order of std::variant types in MaybeOwningDeviceMemory #28947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_783503749
branch
from
d6894ae to
75620cb
Compare
Constructing and destroying trivially-destructible se::DeviceMemoryBase is about 2.5X faster that OwnedDeviceMemory. This code is on a hot path of invoking XLA from Tensorflow: we construct a vector of default-initialized ShapeTree<MaybeOwningDeviceMemory>. PiperOrigin-RevId: 783553450
copybara-service
bot
force-pushed
the
test_783503749
branch
from
75620cb to
da69949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla] Change the order of std::variant types in MaybeOwningDeviceMemory
Constructing and destroying trivially-destructible se::DeviceMemoryBase is about 2.5X faster that OwnedDeviceMemory. This code is on a hot path of invoking XLA from Tensorflow: we construct a vector of default-initialized ShapeTree.