[XLA:GPU] Move the s4 unpacking sequence from llvm pass to int4->int8 pass #28972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
… pass The change does not work properly yet. There is a test where we multiply the int4 to the identity matrix. The test gives us the wrong results. PiperOrigin-RevId: 783708907
copybara-service
bot
force-pushed
the
test_783708907
branch
from
8d32f4f to
6a092f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Move the s4 unpacking sequence from llvm pass to int4->int8 pass
The change does not work properly yet.
There is a test where we multiply the int4 to the identity matrix.
The test gives us the wrong results.