[IFRT] Define user_context() in Value and LoadedExecutable
#29042
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This change defines `user_context()` for IFRT `Value` and `LoadedExecutable`.
This method is expected to return `UserContext` that was supplied during the
value (including array) or loaded executable creation time.
IFRT implementations return `{}` (`== nullptr`) as a placeholder. Their actual
implementation will follow.
These two types are chosen as initial targets for tracking user contexts
because today's IFRT user code frequently attaches their own user context
(e.g., Python traceback) to these objects. Other runtimes objects (e.g.,
`DeviceList`) and state transitions (value deletion) can be future candidates
for additional user context tracking, but it is scoped out for now.
PiperOrigin-RevId: 784284821
copybara-service
bot
force-pushed
the
test_784284821
branch
from
8a05054 to
1726002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IFRT] Define
user_context()inValueandLoadedExecutableThis change defines
user_context()for IFRTValueandLoadedExecutable.This method is expected to return
UserContextthat was supplied during thevalue (including array) or loaded executable creation time.
IFRT implementations return
{}(== nullptr) as a placeholder. Their actualimplementation will follow.
These two types are chosen as initial targets for tracking user contexts
because today's IFRT user code frequently attaches their own user context
(e.g., Python traceback) to these objects. Other runtimes objects (e.g.,
DeviceList) and state transitions (value deletion) can be future candidatesfor additional user context tracking, but it is scoped out for now.